Opened 4 years ago

Closed 4 years ago

#22484 closed enhancement (fixed)

py3 get rid of last call to cmp() in parent.pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 3bbd8bb (Commits, GitHub, GitLab) Commit: 3bbd8bb78797041cf429bb3c0ccff1dc1b0dc806
Dependencies: Stopgaps:

Status badges


as a step to python3

replace a strange use of _cmp_ in a Parent class by a more standard method __richcmp__

Change History (9)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22484
  • Commit set to 6d9179018bf718ce7502e54e53db4d92fb11f46c

New commits:

6d91790py3 try to get rid of last calls to cmp() in parent.pyx

comment:2 Changed 4 years ago by git

  • Commit changed from 6d9179018bf718ce7502e54e53db4d92fb11f46c to 78d856893ed60f2dc5b8f1351d7d9f53f1db4216

Branch pushed to git repo; I updated commit sha1. New commits:

78d8568trac 22484 fixing a detail

comment:3 Changed 4 years ago by chapoton

  • Cc tscrim jdemeyer aapitzsch added

green bot, please review

comment:4 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:5 Changed 4 years ago by jdemeyer

  • Branch changed from u/chapoton/22484 to u/jdemeyer/22484

comment:6 Changed 4 years ago by jdemeyer

  • Commit changed from 78d856893ed60f2dc5b8f1351d7d9f53f1db4216 to 3bbd8bb78797041cf429bb3c0ccff1dc1b0dc806

Same functionality with more efficient code.

New commits:

3bbd8bbMore efficient Set_PythonType.__richcmp__

comment:7 Changed 4 years ago by chapoton

ok, green bot, looks good to me. You can set a positive review if you want.

comment:8 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/22484 to 3bbd8bb78797041cf429bb3c0ccff1dc1b0dc806
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.