Opened 6 years ago

Closed 6 years ago

#22479 closed enhancement (fixed)

py3 more cases of add_metaclass

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ccad7fd (Commits, GitHub, GitLab) Commit: ccad7fd2463bd7f95869f8357a99ac4d9408e24f
Dependencies: Stopgaps:

Status badges


using the very convenient decorator add_metaclass (from six)

here only in a few files

part of #16074

Change History (4)

comment:1 Changed 6 years ago by chapoton

Branch: u/chapoton/22479
Commit: ccad7fd2463bd7f95869f8357a99ac4d9408e24f
Status: newneeds_review

New commits:

ccad7fdpy3 a few more uses of add_metaclass

comment:2 Changed 6 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM (under the assumption the patchbot comes back green).

comment:3 Changed 6 years ago by chapoton


green enough, I think (unrelated doctest failure)

comment:4 Changed 6 years ago by vbraun

Branch: u/chapoton/22479ccad7fd2463bd7f95869f8357a99ac4d9408e24f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.