Opened 4 years ago

Closed 4 years ago

#22479 closed enhancement (fixed)

py3 more cases of add_metaclass

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ccad7fd (Commits) Commit: ccad7fd2463bd7f95869f8357a99ac4d9408e24f
Dependencies: Stopgaps:

Description

using the very convenient decorator add_metaclass (from six)

here only in a few files

part of #16074

Change History (4)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22479
  • Commit set to ccad7fd2463bd7f95869f8357a99ac4d9408e24f
  • Status changed from new to needs_review

New commits:

​ccad7fdpy3 a few more uses of add_metaclass

comment:2 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM (under the assumption the patchbot comes back green).

comment:3 Changed 4 years ago by chapoton

Thanks

green enough, I think (unrelated doctest failure)

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/22479 to ccad7fd2463bd7f95869f8357a99ac4d9408e24f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.