Opened 3 years ago

Closed 3 years ago

#22473 closed defect (fixed)

Remove patchbot optional spkg

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-7.6
Component: coding theory Keywords: days84
Cc: chapoton Merged in:
Authors: Thierry Monteil Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b2810d6 (Commits) Commit: b2810d60b64becc44559d098358ad829964367c5
Dependencies: Stopgaps:

Description

This is an intermediate step toward #20736 which has to be done anyway since the spkg does not work anyway, and will not exist anymore as a Sage spkg.

Change History (11)

comment:1 Changed 3 years ago by tmonteil

  • Branch set to u/tmonteil/remove_patchbot_optional_spkg

comment:2 Changed 3 years ago by git

  • Commit set to ab730ea98812628073d1810b353ccf1c2d0d8f02

Branch pushed to git repo; I updated commit sha1. New commits:

ab730ea#22473 : sage -patchbot command provides a link to the wiki.

comment:3 Changed 3 years ago by tmonteil

I split into two commits :

  • remove the patchbot spkg.
  • modify sage -patchbot command to link to the wiki.

Regarding the discussion of #20736 it is okay for me if only the first commit get accepted.

comment:4 Changed 3 years ago by tmonteil

  • Keywords days84 added

comment:5 Changed 3 years ago by tmonteil

  • Status changed from new to needs_review

comment:6 follow-up: Changed 3 years ago by jdemeyer

I don't agree with the instructions on that wiki page. If this ticket gets merged, I will be forced to edit the wiki page.

comment:7 Changed 3 years ago by tmonteil

  • Cc chapoton added

comment:8 Changed 3 years ago by git

  • Commit changed from ab730ea98812628073d1810b353ccf1c2d0d8f02 to b2810d60b64becc44559d098358ad829964367c5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:9 in reply to: ↑ 6 Changed 3 years ago by tmonteil

Replying to jdemeyer:

I don't agree with the instructions on that wiki page. If this ticket gets merged, I will be forced to edit the wiki page.

OK, I removed the last commit of the branch.

comment:10 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/tmonteil/remove_patchbot_optional_spkg to b2810d60b64becc44559d098358ad829964367c5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.