Opened 4 years ago
Closed 4 years ago
#22425 closed enhancement (fixed)
Update Singular to 4.1.0p2
Reported by: | jpflori | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | packages: standard | Keywords: | days85 |
Cc: | jakobkroeker, jdemeyer, fbissey, vbraun, rlmiller | Merged in: | |
Authors: | Jean-Pierre Flori | Reviewers: | Volker Braun, François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | ea637e6 (Commits, GitHub, GitLab) | Commit: | ea637e692c960beba83b259c9044c87dce64bdf2 |
Dependencies: | Stopgaps: |
Description
New version at:
This should fix warnings in debug mode: #21624
Change History (23)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
Or its due to giac being broken on ppc64, no idea.
comment:3 Changed 4 years ago by
- Commit changed from 6bdcdee6c48bbebdd3674fc3c2469a9f3d2e9bb9 to a204dfc0e0b79c8a81bdfc50aca0e7976875d5fb
Branch pushed to git repo; I updated commit sha1. New commits:
a204dfc | Further easy fixes.
|
comment:4 Changed 4 years ago by
- Commit changed from a204dfc0e0b79c8a81bdfc50aca0e7976875d5fb to 400fce181981a49abea6e13ee469ff9b44a7ceb3
comment:5 Changed 4 years ago by
- Status changed from new to needs_review
I'm not sure this is in a review state as my ppc64 spits a lot of giac related errors, but feel free to finish this ticket as I will be away from the internet for a couple of weeks.
comment:6 Changed 4 years ago by
- Cc vbraun added
Anyone? @volker: this should simplify your life as the patch bot building in debug mode won't have singular related errors anymore.
comment:7 Changed 4 years ago by
- Status changed from needs_review to positive_review
I'll give it a whirl ...
comment:8 Changed 4 years ago by
- Reviewers set to Volker Braun
comment:9 Changed 4 years ago by
- Status changed from positive_review to needs_work
Doesn't work:
[singular-4.1.0p2] 1 out of 1 hunk ignored -- saving rejects to file kernel/spectrum/test.cc.rej [singular-4.1.0p2] patching file kernel/test.cc [singular-4.1.0p2] Reversed (or previously applied) patch detected! Assume -R? [n] [singular-4.1.0p2] Apply anyway? [n] [singular-4.1.0p2] Skipping patch. [singular-4.1.0p2] 1 out of 1 hunk ignored -- saving rejects to file kernel/test.cc.rej [singular-4.1.0p2] patching file libpolys/tests/rings_test.h [singular-4.1.0p2] Reversed (or previously applied) patch detected! Assume -R? [n] [singular-4.1.0p2] Apply anyway? [n] [singular-4.1.0p2] Skipping patch. [singular-4.1.0p2] 1 out of 1 hunk ignored -- saving rejects to file libpolys/tests/rings_test.h.rej [singular-4.1.0p2] Error applying '../patches/make_check.patch'
comment:10 Changed 4 years ago by
It looks like the patch has been included in upstream tarball. So yes the tarball is the tagged git branch plus this patch at least - dubious. I'll push a fix in a few hours.
comment:11 Changed 4 years ago by
- Commit changed from 400fce181981a49abea6e13ee469ff9b44a7ceb3 to 53385ed4769763b3c3c4370dff367f0b5888ce81
Branch pushed to git repo; I updated commit sha1. New commits:
53385ed | Remove patch already included in upstream tarball
|
comment:12 Changed 4 years ago by
- Reviewers changed from Volker Braun to Volker Braun, François Bissey
- Status changed from needs_work to positive_review
Fixed.
comment:13 Changed 4 years ago by
- Status changed from positive_review to needs_work
Seems to have a different normalization:
sage -t --long src/sage/schemes/affine/affine_morphism.py ********************************************************************** File "src/sage/schemes/affine/affine_morphism.py", line 672, in sage.schemes.affine.affine_morphism.SchemeMorphism_polynomial_affine_space.dynatomic_polynomial Failed example: F.dynatomic_polynomial([1,1]) Expected: (2.00000000000000*x^4 + 5.85640646055102*x^2 + 24.0000000000000)/(x^2 + (-2.00000000000000)*x + 3.46410161513775) Got: (0.125000000000000*x^4 + 0.366025403784439*x^2 + 1.50000000000000)/(0.500000000000000*x^2 - x + 1.73205080756888) ********************************************************************** 1 item had failures: 1 of 39 in sage.schemes.affine.affine_morphism.SchemeMorphism_polynomial_affine_space.dynatomic_polynomial [295 tests, 1 failure, 1.78 s]
comment:14 Changed 4 years ago by
Is that the only failure?
comment:15 Changed 4 years ago by
yes
comment:16 Changed 4 years ago by
One email notification in 10 posts. trac has problems sending email again?
comment:17 Changed 4 years ago by
- Cc rlmiller added
This failing test was added at #22265. @rlmiller: any idea of what might have changed?
comment:18 Changed 4 years ago by
Ok, only a normalization change, roots did not change. It's just I'm not that good at multiplication by 16.
comment:19 Changed 4 years ago by
- Commit changed from 53385ed4769763b3c3c4370dff367f0b5888ce81 to ea637e692c960beba83b259c9044c87dce64bdf2
comment:20 Changed 4 years ago by
- Status changed from needs_work to positive_review
comment:21 Changed 4 years ago by
- Keywords days85 added
comment:22 Changed 4 years ago by
Any chance of getting this merged for 7.6?
comment:23 Changed 4 years ago by
- Branch changed from public/singular410p2 to ea637e692c960beba83b259c9044c87dce64bdf2
- Resolution set to fixed
- Status changed from positive_review to closed
On a ppc64, I get a bunch of
which look pynac related and singular unrelated. In fact I seem to get them on a pristine 7.6beta4.