Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22418 closed enhancement (fixed)

Always use V=1 for logfiles

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.6
Component: build Keywords:
Cc: mkoeppe Merged in:
Authors: Jeroen Demeyer Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: dcc3ba5 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

With #21539, Sage globally supports a V=0 mode. In this mode, the individual logfiles are created with V=1. But this leads to surprising behaviour because some packages have V=0 by default. So a build with V=0 can actually be more verbose than a build with V unset.

Instead, always unconditionally use V=1 for individual packages.

Change History (11)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Cc mkoeppe added

comment:3 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/always_use_v_1_for_logfiles

comment:6 Changed 3 years ago by jdemeyer

  • Commit set to dcc3ba5a35e222746678acb346440922cbefa0e7
  • Status changed from new to needs_review

New commits:

dcc3ba5Always use V=1 for logfiles

comment:7 follow-up: Changed 3 years ago by mkoeppe

This looks fine; but I just noticed that (with or without this ticket) this works for V=0 make but not for make V=0 because in the latter case MAKEFLAGS is set to V=0 and can't be overridden by the environment variable.

comment:8 in reply to: ↑ 7 Changed 3 years ago by jdemeyer

Replying to mkoeppe:

This looks fine; but I just noticed that (with or without this ticket) this works for V=0 make but not for make V=0 because in the latter case MAKEFLAGS is set to V=0 and can't be overridden by the environment variable.

That is a different issue which is unrelated to this ticket.

comment:9 Changed 3 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/always_use_v_1_for_logfiles to dcc3ba5a35e222746678acb346440922cbefa0e7
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 3 years ago by mkoeppe

  • Commit dcc3ba5a35e222746678acb346440922cbefa0e7 deleted

Follow-up: #22492

Note: See TracTickets for help on using tickets.