Changes between Initial Version and Version 1 of Ticket #22416, comment 11
- Timestamp:
- 02/28/17 15:31:24 (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #22416, comment 11
initial v1 7 7 * since you only do comparisons with the circumradius, you should not compute it, but use its square (computing the square root can be very costly in some rings). 8 8 * `row_data` shoud be `raw_data`. 9 * Why not returning a boolean when `certificate` is set to `False` ? The problem here is that 10 `bool((False,None))` is `True`, so that this will cause issues if the method is used within `if` statements. 9 * Why not returning a boolean when `certificate` is set to `False` ? The problem here is that `bool((False,None))` is `True`, so that this will cause issues if the method is used within `if` statements.