Opened 4 years ago

Closed 4 years ago

#22413 closed enhancement (fixed)

doc cleanup in ell_rational_field

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: elliptic curves Keywords:
Cc: cremona, wuthrich, roed Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 3c5e3ba (Commits, GitHub, GitLab) Commit: 3c5e3bac598007e354b2bc220d18a623b463c99a
Dependencies: Stopgaps:

Status badges


some spring cleanup, just for the documentation in the file

also removes methods that were deprecated in #8118 (some time ago!)

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22413
  • Commit set to 3c5e3bac598007e354b2bc220d18a623b463c99a
  • Status changed from new to needs_review

New commits:

3c5e3basome doc cleanup in ell_rational_field and 2 neighbor files

comment:2 Changed 4 years ago by cremona

I read through the diffs and all looks good. Because of the removal of deprecated functions, I think I had better actually run some tests too...

comment:3 Changed 4 years ago by chapoton

I just launched my bot on the ticket, should be done in 3 hours approx.

comment:4 Changed 4 years ago by cremona

  • Reviewers set to John Cremona

OK -- I only tested the elliptic_curves directory which will not take long (many cores): tests pass.

You can give yourself a positive review when your own tests finish successfully.

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

green bot, setting to positive, thanks for the review

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/22413 to 3c5e3bac598007e354b2bc220d18a623b463c99a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.