Opened 6 years ago
Closed 6 years ago
#22411 closed enhancement (fixed)
Improve handling of MtxLibDir
| Reported by: | jdemeyer | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.0 |
| Component: | packages: optional | Keywords: | |
| Cc: | SimonKing | Merged in: | |
| Authors: | Jeroen Demeyer | Reviewers: | Simon King, Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 1a9ac6f (Commits, GitHub, GitLab) | Commit: | 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c |
| Dependencies: | Stopgaps: |
Status badges
Description
Change History (8)
comment:1 follow-up: 2 Changed 6 years ago by
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
| Branch: | → u/jdemeyer/improve_handling_of_mtxlibdir |
|---|
comment:4 Changed 6 years ago by
| Commit: | → 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c |
|---|---|
| Status: | new → needs_review |
I'm adding a simple patch here which makes sense by itself. Further changes will be for other tickets.
New commits:
| 1a9ac6f | Declare MtxLibDir size in header file + increase to 1024 bytes
|
comment:5 follow-up: 6 Changed 6 years ago by
LGTM. But would the patchbots test this with the optional meataxe package installed?
comment:6 Changed 6 years ago by
Replying to SimonKing:
LGTM. But would the patchbots test this with the optional meataxe package installed?
Only the patchbots which have meataxe installed. I believe that arando does at least.
comment:7 Changed 6 years ago by
| Milestone: | sage-7.6 → sage-8.0 |
|---|---|
| Reviewers: | → Simon King, Travis Scrimshaw |
| Status: | needs_review → positive_review |
Tested and everything seems to work.
comment:8 Changed 6 years ago by
| Branch: | u/jdemeyer/improve_handling_of_mtxlibdir → 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Isn't that part of #20136 or #21437?