Opened 4 years ago

Closed 4 years ago

#22411 closed enhancement (fixed)

Improve handling of MtxLibDir

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: packages: optional Keywords:
Cc: SimonKing Merged in:
Authors: Jeroen Demeyer Reviewers: Simon King, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1a9ac6f (Commits, GitHub, GitLab) Commit: 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c
Dependencies: Stopgaps:

Status badges

Description


Change History (8)

comment:1 follow-up: Changed 4 years ago by SimonKing

Isn't that part of #20136 or #21437?

comment:2 in reply to: ↑ 1 Changed 4 years ago by jdemeyer

Replying to SimonKing:

Isn't that part of #20136 or #21437?

Maybe it could be made part of those. It will certainly conflict with #21437.

Since I'm already working on this anyway, let me continue and then look at what should happen.

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/improve_handling_of_mtxlibdir

comment:4 Changed 4 years ago by jdemeyer

  • Commit set to 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c
  • Status changed from new to needs_review

I'm adding a simple patch here which makes sense by itself. Further changes will be for other tickets.

New commits:

​1a9ac6fDeclare MtxLibDir size in header file + increase to 1024 bytes

comment:5 follow-up: Changed 4 years ago by SimonKing

LGTM. But would the patchbots test this with the optional meataxe package installed?

comment:6 in reply to: ↑ 5 Changed 4 years ago by jdemeyer

Replying to SimonKing:

LGTM. But would the patchbots test this with the optional meataxe package installed?

Only the patchbots which have meataxe installed. I believe that arando does at least.

comment:7 Changed 4 years ago by tscrim

  • Milestone changed from sage-7.6 to sage-8.0
  • Reviewers set to Simon King, Travis Scrimshaw
  • Status changed from needs_review to positive_review

Tested and everything seems to work.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/improve_handling_of_mtxlibdir to 1a9ac6f1eb7b4c1da8e14864beae802b75636c2c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.