Opened 4 years ago

Closed 2 years ago

#22409 closed task (duplicate)

Debian u1 patches

Reported by: infinity0 Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: misc Keywords:
Cc: Merged in:
Authors: Ximin Luo, Tobias Hansen, Jerome Benoit Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

This ticket lists some Debian patches that we're applying to Sage. They should be fairly non-controversial.

(We have other patches which need some more work and discussion; I'll be submitting those later as well.)

These were taken from our 7.5.1 branch, which is a WIP. They applied cleanly to 7.6, apart from a trivial merge conflict fix in the case of "Don't fail plot.py". However I haven't tested it on a non-Debian install yet (I don't have the build resources for that right this minute).

Change History (15)

comment:1 Changed 4 years ago by infinity0

  • Branch set to u/infinity0/debian_u1_patches

comment:2 Changed 4 years ago by infinity0

  • Commit set to e9baf215437d192653d36a8e3d1ff654ca052a68
  • Component changed from PLEASE CHANGE to misc
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

New commits:

​084b452Use system paths for libGAP
​d1ce385Use lexists instead of exists
​317aef6Fix Sage's use of scipy rtol parameter
​b50511fWork around python bug #1652
​29962ecDon't fail plot.py doctest if DISPLAY is unset
​9dd9258Compile pynac interface with SINGULAR_CFLAGS to find its headers
​e9baf21Do not test the version of glpk

comment:3 Changed 4 years ago by git

  • Commit changed from e9baf215437d192653d36a8e3d1ff654ca052a68 to 27d41fa682b68e941b0657459eeeaaa298725bef

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​bd439fbUse system paths for libGAP
​b91b5a7Use lexists instead of exists
​49b5625Fix Sage's use of scipy rtol parameter
​9bbcedaWork around python bug #1652
​6ac7288Don't fail plot.py doctest if DISPLAY is unset
​68152dfCompile pynac interface with SINGULAR_CFLAGS to find its headers
​27d41faDo not test the version of glpk

comment:4 Changed 4 years ago by infinity0

Re-did the commits because the older ones leaked my local host name. Whoops...

comment:5 Changed 4 years ago by infinity0

  • Authors set to Ximin Luo, Tobias Hansen, Jerome Benoit
  • Report Upstream changed from N/A to None of the above - read trac for reasoning.
  • Status changed from new to needs_review

comment:6 Changed 4 years ago by git

  • Commit changed from 27d41fa682b68e941b0657459eeeaaa298725bef to 399f911afa6e1ed073d9f80794edd95d9975ebdf

Branch pushed to git repo; I updated commit sha1. New commits:

​316c6c3Fix atrocious logic in symlink()
​399f911Make sage.doctest.sources.get_basename work in more situations

comment:7 Changed 4 years ago by infinity0

  • Report Upstream changed from None of the above - read trac for reasoning. to N/A

comment:8 Changed 4 years ago by jdemeyer

I would much prefer to have one ticket for each issue that you are fixing instead of grouping together a bunch of unrelated patches.

comment:9 follow-up: Changed 4 years ago by infinity0

Some of these commits are very small and opening a new ticket just for a single-line commit seems like unnecessary overhead. The libgap and scipy ones are a bit larger. Shall I still split everything or would you be happy with me splitting out only these two?

comment:10 in reply to: ↑ 9 Changed 4 years ago by jdemeyer

One ticket per issue. If that means 10 tickets, then so be it.

comment:11 Changed 4 years ago by infinity0

Reopened as #22437, #22438, #22439, #22440, #22441, #22442, #22443, #22444, #22445.

You can close this ticket. I tried but it doesn't look like I have the permissions.

comment:12 Changed 4 years ago by vdelecroix

  • Branch u/infinity0/debian_u1_patches deleted
  • Commit 399f911afa6e1ed073d9f80794edd95d9975ebdf deleted
  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Type changed from defect to task

Better to keep this ticket as a task ticket... changed accordingly

comment:13 Changed 4 years ago by vdelecroix

(and thanks for the effort of proposing the patches to Sage!)

comment:14 Changed 4 years ago by infinity0

welcome! I've fixed the missing branches, I think it is something to do with the fact that trac logs me out every 10 minutes or so (because I connect through Tor).. will keep an eye out on that in the future

comment:15 Changed 2 years ago by jdemeyer

  • Milestone changed from sage-7.6 to sage-duplicate/invalid/wontfix
  • Resolution set to duplicate
  • Status changed from needs_work to closed
Note: See TracTickets for help on using tickets.