Opened 6 years ago
Closed 4 years ago
#22409 closed task (duplicate)
Debian u1 patches
Reported by: | infinity0 | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | misc | Keywords: | |
Cc: | Merged in: | ||
Authors: | Ximin Luo, Tobias Hansen, Jerome Benoit | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This ticket lists some Debian patches that we're applying to Sage. They should be fairly non-controversial.
(We have other patches which need some more work and discussion; I'll be submitting those later as well.)
These were taken from our 7.5.1 branch, which is a WIP. They applied cleanly to 7.6, apart from a trivial merge conflict fix in the case of "Don't fail plot.py". However I haven't tested it on a non-Debian install yet (I don't have the build resources for that right this minute).
Change History (15)
comment:1 Changed 6 years ago by
Branch: | → u/infinity0/debian_u1_patches |
---|
comment:2 Changed 6 years ago by
Commit: | → e9baf215437d192653d36a8e3d1ff654ca052a68 |
---|---|
Component: | PLEASE CHANGE → misc |
Description: | modified (diff) |
Type: | PLEASE CHANGE → defect |
comment:3 Changed 6 years ago by
Commit: | e9baf215437d192653d36a8e3d1ff654ca052a68 → 27d41fa682b68e941b0657459eeeaaa298725bef |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bd439fb | Use system paths for libGAP
|
b91b5a7 | Use lexists instead of exists
|
49b5625 | Fix Sage's use of scipy rtol parameter
|
9bbceda | Work around python bug #1652
|
6ac7288 | Don't fail plot.py doctest if DISPLAY is unset
|
68152df | Compile pynac interface with SINGULAR_CFLAGS to find its headers
|
27d41fa | Do not test the version of glpk
|
comment:4 Changed 6 years ago by
Re-did the commits because the older ones leaked my local host name. Whoops...
comment:5 Changed 6 years ago by
Authors: | → Ximin Luo, Tobias Hansen, Jerome Benoit |
---|---|
Report Upstream: | N/A → None of the above - read trac for reasoning. |
Status: | new → needs_review |
comment:6 Changed 6 years ago by
Commit: | 27d41fa682b68e941b0657459eeeaaa298725bef → 399f911afa6e1ed073d9f80794edd95d9975ebdf |
---|
comment:7 Changed 6 years ago by
Report Upstream: | None of the above - read trac for reasoning. → N/A |
---|
comment:8 Changed 6 years ago by
I would much prefer to have one ticket for each issue that you are fixing instead of grouping together a bunch of unrelated patches.
comment:9 follow-up: 10 Changed 6 years ago by
Some of these commits are very small and opening a new ticket just for a single-line commit seems like unnecessary overhead. The libgap and scipy ones are a bit larger. Shall I still split everything or would you be happy with me splitting out only these two?
comment:11 Changed 6 years ago by
comment:12 Changed 6 years ago by
Branch: | u/infinity0/debian_u1_patches |
---|---|
Commit: | 399f911afa6e1ed073d9f80794edd95d9975ebdf |
Description: | modified (diff) |
Status: | needs_review → needs_work |
Type: | defect → task |
Better to keep this ticket as a task ticket... changed accordingly
comment:14 Changed 6 years ago by
welcome! I've fixed the missing branches, I think it is something to do with the fact that trac logs me out every 10 minutes or so (because I connect through Tor).. will keep an eye out on that in the future
comment:15 Changed 4 years ago by
Milestone: | sage-7.6 → sage-duplicate/invalid/wontfix |
---|---|
Resolution: | → duplicate |
Status: | needs_work → closed |
New commits:
Use system paths for libGAP
Use lexists instead of exists
Fix Sage's use of scipy rtol parameter
Work around python bug #1652
Don't fail plot.py doctest if DISPLAY is unset
Compile pynac interface with SINGULAR_CFLAGS to find its headers
Do not test the version of glpk