Opened 4 years ago

Closed 3 years ago

#22400 closed enhancement (fixed)

Transpose text databases of reflexive polytopes for PALP

Reported by: novoselt Owned by:
Priority: major Milestone: sage-7.6
Component: packages: standard Keywords:
Cc: vbraun Merged in:
Authors: Andrey Novoseltsev Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: f42ea43 (Commits) Commit: f42ea43a88329352349c8b7b6831afccc658ec92
Dependencies: Stopgaps:

Description

We store reflexive polytopes in 2 and 3 dimensions as text files. The current version lists points as columns of matrices, but the default output for PALP is reversed and it gives cleaner code not handle two cases. The main point, however, is that it would be faster to construct reflexive polytopes lists in memory if files were written point by point.

The current code in Sage will accept both old and new versions of the database, while the new one I am (re)writing will work only with the new one.

There is also a comment in SPKG.txt (exactly five years old) that text files will be removed in favour of the also included binary ones. However this didn't happen yet and I think it makes sense to keep small lists in plain form which is so easy to parse directly in Python without relying on any database modules or PALP itself for that matter.

Attachments (1)

polytopes_db-20170220.tar.bz2​ (32.5 KB) - added by novoselt 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by novoselt

comment:1 Changed 4 years ago by novoselt

  • Branch set to u/novoselt/transpose_lattice_polytopes

comment:2 Changed 4 years ago by novoselt

  • Commit set to f42ea43a88329352349c8b7b6831afccc658ec92
  • Status changed from new to needs_review

New commits:

​f42ea43Transpose databases of small reflexive polytopes

comment:3 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/novoselt/transpose_lattice_polytopes to f42ea43a88329352349c8b7b6831afccc658ec92
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.