Opened 4 years ago
Closed 4 years ago
#22392 closed defect (fixed)
AsymptoticRingFunctor does not deal with derived classes
Reported by: | dkrenn | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | asymptotic expansions | Keywords: | |
Cc: | cheuberg, behackl | Merged in: | |
Authors: | Daniel Krenn | Reviewers: | Clemens Heuberger |
Report Upstream: | N/A | Work issues: | |
Branch: | 4dce6f5 (Commits) | Commit: | 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686 |
Dependencies: | Stopgaps: |
Description
We should have
sage: from sage.rings.asymptotic.asymptotic_ring import AsymptoticRing sage: class MyAsymptoticRing(AsymptoticRing): ....: pass sage: A = MyAsymptoticRing(growth_group='x^ZZ', coefficient_ring=QQ) sage: C = CyclotomicField(3) sage: P = C['z'] sage: type(P(2) * A.gen()) <class '...MyAsymptoticRing_with_category.element_class'>
but the element returned is has type AsymptoticRing
(without the My
).
Change History (7)
comment:1 Changed 4 years ago by
- Branch set to u/dkrenn/asy-functor-derive-bug
comment:2 Changed 4 years ago by
- Cc cheuberg behackl added
- Commit set to f6d4502607c8fa7f1d0e54f10d52aae6e61c2c64
- Status changed from new to needs_review
comment:3 Changed 4 years ago by
- Branch changed from u/dkrenn/asy-functor-derive-bug to u/cheuberg/asy-functor-derive-bug
comment:4 follow-up: ↓ 5 Changed 4 years ago by
- Commit changed from f6d4502607c8fa7f1d0e54f10d52aae6e61c2c64 to 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686
- Status changed from needs_review to positive_review
LGTM. Added one reviewer commit (mention trac ticket in Tests).
New commits:
4dce6f5 | Trac #22392: Mention Trac Ticket in Tests
|
comment:5 in reply to: ↑ 4 Changed 4 years ago by
comment:6 Changed 4 years ago by
- Reviewers set to Clemens Heuberger
comment:7 Changed 4 years ago by
- Branch changed from u/cheuberg/asy-functor-derive-bug to 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Trac #22392: new parameter cls
Trac #22392: pass cls from AsymptoticRing.construction
Trac #22392: use new parameter cls
Trac #22392: adapt repr