Opened 3 years ago

Closed 3 years ago

#22392 closed defect (fixed)

AsymptoticRingFunctor does not deal with derived classes

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.6
Component: asymptotic expansions Keywords:
Cc: cheuberg, behackl Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 4dce6f5 (Commits) Commit: 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686
Dependencies: Stopgaps:

Description

We should have 

            sage: from sage.rings.asymptotic.asymptotic_ring import AsymptoticRing
            sage: class MyAsymptoticRing(AsymptoticRing):
            ....:     pass
            sage: A = MyAsymptoticRing(growth_group='x^ZZ', coefficient_ring=QQ)

            sage: C = CyclotomicField(3)
            sage: P = C['z']
            sage: type(P(2) * A.gen())
            <class '...MyAsymptoticRing_with_category.element_class'>

but the element returned is has type AsymptoticRing (without the My).

Change History (7)

comment:1 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/asy-functor-derive-bug

comment:2 Changed 3 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Cc cheuberg behackl added
  • Commit set to f6d4502607c8fa7f1d0e54f10d52aae6e61c2c64
  • Status changed from new to needs_review

New commits:

​4ddcdc3Trac #22392: new parameter cls
​45728ffTrac #22392: pass cls from AsymptoticRing.construction
​0982d06Trac #22392: use new parameter cls
​f6d4502Trac #22392: adapt repr

comment:3 Changed 3 years ago by cheuberg

  • Branch changed from u/dkrenn/asy-functor-derive-bug to u/cheuberg/asy-functor-derive-bug

comment:4 follow-up: Changed 3 years ago by cheuberg

  • Commit changed from f6d4502607c8fa7f1d0e54f10d52aae6e61c2c64 to 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686
  • Status changed from needs_review to positive_review

LGTM. Added one reviewer commit (mention trac ticket in Tests).

New commits:

​4dce6f5Trac #22392: Mention Trac Ticket in Tests

comment:5 in reply to: ↑ 4 Changed 3 years ago by dkrenn

Replying to cheuberg:

LGTM. Added one reviewer commit (mention trac ticket in Tests).

Thank you.

comment:6 Changed 3 years ago by cheuberg

  • Reviewers set to Clemens Heuberger

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/cheuberg/asy-functor-derive-bug to 4dce6f5733ce2d0efa3e1e5cf3afbac279cb1686
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.