Opened 6 years ago
Closed 6 years ago
#22385 closed enhancement (fixed)
py3: next round of cleanup for zip
Reported by: | Frédéric Chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 6c508aa (Commits, GitHub, GitLab) | Commit: | 6c508aafed3ee97aa6d03a352cbf5ae2125a8c34 |
Dependencies: | Stopgaps: |
Description
part of #16082, on the road to python 3
Change History (8)
comment:1 Changed 6 years ago by
Branch: | → u/chapoton/22385 |
---|---|
Commit: | → f657f4fc307913ef03efaae069f91270d72a47a7 |
Status: | new → needs_review |
comment:2 Changed 6 years ago by
Status: | needs_review → needs_work |
---|
comment:3 Changed 6 years ago by
Commit: | f657f4fc307913ef03efaae069f91270d72a47a7 → 155f15ee178f09091ef12bfb4749a5b09f8c3ea2 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
155f15e | trac 22385 fix one zip
|
comment:4 Changed 6 years ago by
Status: | needs_work → needs_review |
---|
comment:5 Changed 6 years ago by
Reviewers: | → Travis Scrimshaw |
---|
Little thing, in combinat/sf/schur.py
we could change:
- zipped_beta_list = list(zip(beta_list, range(1, ns + 1))) - zipped_beta_list.sort(key=lambda a: (- 1 - a[0]) % n) + zipped_beta_list = sorted(zip(beta_list, range(1, ns + 1)), + key=lambda a: (- 1 - a[0]) % n)
If the patchbot comes back green, then positive review.
comment:6 Changed 6 years ago by
Commit: | 155f15ee178f09091ef12bfb4749a5b09f8c3ea2 → 6c508aafed3ee97aa6d03a352cbf5ae2125a8c34 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
6c508aa | trac 22385 a detail
|
comment:7 Changed 6 years ago by
Status: | needs_review → positive_review |
---|
green bot, setting to positive review, thanks
comment:8 Changed 6 years ago by
Branch: | u/chapoton/22385 → 6c508aafed3ee97aa6d03a352cbf5ae2125a8c34 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
let us wait for the bots
New commits:
py3 another round of cleanup for zip