Opened 3 years ago

Closed 3 years ago

#22384 closed enhancement (fixed)

coerce.pyx: don't use parent as variable name

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-7.6
Component: coercion Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 836ebcb (Commits) Commit: 836ebcbacf1d79e39806b635b35318a97991838a
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Use parent for the function instead of a local variable.

We also remove the unused return type Parent of the method division_parent.

Change History (6)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Cc tscrim added

comment:3 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/coerce_pyx__don_t_use_parent_as_variable_name

comment:4 Changed 3 years ago by jdemeyer

  • Commit set to 836ebcbacf1d79e39806b635b35318a97991838a
  • Status changed from new to needs_review

New commits:

836ebcbDon't use "parent" as variable name

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/coerce_pyx__don_t_use_parent_as_variable_name to 836ebcbacf1d79e39806b635b35318a97991838a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.