Opened 4 years ago

Closed 4 years ago

#22383 closed enhancement (fixed)

Use "yield" in CGraphBackend.iterator_verts

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.6
Component: graph theory Keywords:
Cc: mmezzarobba Merged in:
Authors: Jeroen Demeyer Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 507428d (Commits) Commit: 507428d7ecf68761d2ce2f56339da365e9383677
Dependencies: Stopgaps:


Instead of constructing some container and then returning an iterator over that container, use yield directly.

Change History (5)

comment:1 Changed 4 years ago by jdemeyer

  • Summary changed from Use "yield" in c_graph.iterator_verts to Use "yield" in CGraphBackend.iterator_verts

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/use__yield__in_c_graph_iterator_verts

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 507428d7ecf68761d2ce2f56339da365e9383677
  • Status changed from new to needs_review

New commits:

507428dUse "yield" in CGraphBackend.iterator_verts

comment:4 Changed 4 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

Passes all tests on src/sage/graphs/, and the changes in the doctests are correct (I checked). So good to go.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/use__yield__in_c_graph_iterator_verts to 507428d7ecf68761d2ce2f56339da365e9383677
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.