Opened 6 years ago
Closed 6 years ago
#22383 closed enhancement (fixed)
Use "yield" in CGraphBackend.iterator_verts
| Reported by: | jdemeyer | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-7.6 |
| Component: | graph theory | Keywords: | |
| Cc: | mmezzarobba | Merged in: | |
| Authors: | Jeroen Demeyer | Reviewers: | David Coudert |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 507428d (Commits, GitHub, GitLab) | Commit: | 507428d7ecf68761d2ce2f56339da365e9383677 |
| Dependencies: | Stopgaps: |
Status badges
Description
Instead of constructing some container and then returning an iterator over that container, use yield directly.
Change History (5)
comment:1 Changed 6 years ago by
| Summary: | Use "yield" in c_graph.iterator_verts → Use "yield" in CGraphBackend.iterator_verts |
|---|
comment:2 Changed 6 years ago by
| Branch: | → u/jdemeyer/use__yield__in_c_graph_iterator_verts |
|---|
comment:3 Changed 6 years ago by
| Commit: | → 507428d7ecf68761d2ce2f56339da365e9383677 |
|---|---|
| Status: | new → needs_review |
comment:4 Changed 6 years ago by
| Reviewers: | → David Coudert |
|---|---|
| Status: | needs_review → positive_review |
Passes all tests on src/sage/graphs/, and the changes in the doctests are correct (I checked). So good to go.
comment:5 Changed 6 years ago by
| Branch: | u/jdemeyer/use__yield__in_c_graph_iterator_verts → 507428d7ecf68761d2ce2f56339da365e9383677 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Use "yield" in CGraphBackend.iterator_verts