Opened 6 years ago

Closed 6 years ago

#22383 closed enhancement (fixed)

Use "yield" in CGraphBackend.iterator_verts

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.6
Component: graph theory Keywords:
Cc: mmezzarobba Merged in:
Authors: Jeroen Demeyer Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 507428d (Commits, GitHub, GitLab) Commit: 507428d7ecf68761d2ce2f56339da365e9383677
Dependencies: Stopgaps:

Status badges

Description

Instead of constructing some container and then returning an iterator over that container, use yield directly.

Change History (5)

comment:1 Changed 6 years ago by jdemeyer

Summary: Use "yield" in c_graph.iterator_vertsUse "yield" in CGraphBackend.iterator_verts

comment:2 Changed 6 years ago by jdemeyer

Branch: u/jdemeyer/use__yield__in_c_graph_iterator_verts

comment:3 Changed 6 years ago by jdemeyer

Commit: 507428d7ecf68761d2ce2f56339da365e9383677
Status: newneeds_review

New commits:

507428dUse "yield" in CGraphBackend.iterator_verts

comment:4 Changed 6 years ago by dcoudert

Reviewers: David Coudert
Status: needs_reviewpositive_review

Passes all tests on src/sage/graphs/, and the changes in the doctests are correct (I checked). So good to go.

comment:5 Changed 6 years ago by vbraun

Branch: u/jdemeyer/use__yield__in_c_graph_iterator_verts507428d7ecf68761d2ce2f56339da365e9383677
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.