Opened 5 years ago
Closed 5 years ago
#22379 closed enhancement (fixed)
py3: simplify richcmp of integer ring and polynomial classes
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  python3  Keywords:  
Cc:  jmantysalo, tscrim, aapitzsch, jdemeyer  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  58890e5 (Commits, GitHub, GitLab)  Commit:  58890e5ae2dd40e696403d333690b56bf46a7e3a 
Dependencies:  Stopgaps: 
Description (last modified by )
By getting rid of the calls to _richcmp
.
This is a first step towards the aim of getting rid of _richcmp
everywhere. There will remain to handle 2 other calls elsewhere.
Change History (10)
comment:1 Changed 5 years ago by
 Branch set to u/chapoton/22379
 Commit set to 1564b84df82c99a72e1b013640f56d7e8db7b027
comment:2 Changed 5 years ago by
I'd rather fix this as part of #22344.
comment:3 Changed 5 years ago by
 Commit changed from 1564b84df82c99a72e1b013640f56d7e8db7b027 to 6fde1263ed53dc6790b67e36b509be53fd24e33a
comment:4 Changed 5 years ago by
 Commit changed from 6fde1263ed53dc6790b67e36b509be53fd24e33a to 0e413822360448acefd570c20fa140da555858e9
Branch pushed to git repo; I updated commit sha1. New commits:
0e41382  trac 22379 some doctests fixed

comment:5 Changed 5 years ago by
 Commit changed from 0e413822360448acefd570c20fa140da555858e9 to 1284b260be18bc7885ef14affe335fb9586bce51
Branch pushed to git repo; I updated commit sha1. New commits:
1284b26  trac 22379 fixing doctests in a better way

comment:6 Changed 5 years ago by
 Cc jmantysalo tscrim aapitzsch jdemeyer added
 Description modified (diff)
 Status changed from new to needs_review
 Summary changed from py3: try to simplify richcmp of integer ring class to py3: simplify richcmp of integer ring and polynomial classes
it seems that the bot is mostly green, please review
comment:7 Changed 5 years ago by
 Commit changed from 1284b260be18bc7885ef14affe335fb9586bce51 to 58890e5ae2dd40e696403d333690b56bf46a7e3a
Branch pushed to git repo; I updated commit sha1. New commits:
58890e5  trac 22379 undo one unnecessary change

comment:8 Changed 5 years ago by
Bot is now squarely green.
This is a simplification of the comparison framework. Once the same thing is done in #22427 for the remaining 2 calls to _richcmp
(in complex numbers), one will be able to get rid of _richcmp
. Let me recall that handling the comparison is one of the major problems standing on our way to python3.
comment:9 Changed 5 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
While I fundamentally agree with Jeroen, I think it is better for us to make progress in the more immediate as work on #22344 has currently stalled.
comment:10 Changed 5 years ago by
 Branch changed from u/chapoton/22379 to 58890e5ae2dd40e696403d333690b56bf46a7e3a
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
py3 : try to simplify (rich)cmp of IntegerRing_class