Opened 3 years ago

Closed 3 years ago

#22360 closed defect (fixed)

singularity analysis: raise proper OZero-exception (instead of AttributeError)

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.6
Component: asymptotic expansions Keywords:
Cc: cheuberg, behackl Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: fca3448 (Commits) Commit: fca34489a2fea0f3546b94a8151090b4a5089870
Dependencies: Stopgaps:

Description (last modified by cheuberg)

            sage: C.<T> = AsymptoticRing('T^QQ', QQ)
            sage: (1/T)._singularity_analysis_('n', 1)

fails with an AttributeError, as the Python-integer 0 has no method is_exact. Raise a NotImplementedOZero instead as expected.

Change History (5)

comment:1 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/asy/sa-OZero-0-bug

comment:2 Changed 3 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Cc cheuberg behackl added
  • Commit set to fca34489a2fea0f3546b94a8151090b4a5089870
  • Status changed from new to needs_review

New commits:

b72b0c2fix bug
fca3448add doctest

comment:3 Changed 3 years ago by cheuberg

  • Description modified (diff)
  • Reviewers set to Clemens Heuberger

Judging from the diff, this looks fine. I'll set this to positive review once my machine finishes compilation of 7.6.beta2.

comment:4 Changed 3 years ago by cheuberg

  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/dkrenn/asy/sa-OZero-0-bug to fca34489a2fea0f3546b94a8151090b4a5089870
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.