Opened 4 years ago
Closed 4 years ago
#22357 closed enhancement (fixed)
Test for Python 3 syntax
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  python3  Keywords:  days85 
Cc:  tscrim, jdemeyer, aapitzsch  Merged in:  
Authors:  Volker Braun  Reviewers:  Julian Rüth, Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  1176203 (Commits, GitHub, GitLab)  Commit:  1176203f95f7b30be2f332665f5d607b1ec87798 
Dependencies:  Stopgaps: 
Description
We should have tests to avoid Py3 regressions as people work on other tickets. One lowhanging fruit to be implemented on this ticket is to compile with python3 and check for syntax errors
Change History (19)
comment:1 Changed 4 years ago by
 Branch set to u/vbraun/test_for_python_3_syntax
comment:2 Changed 4 years ago by
 Commit set to efff0c4593822a80695a1ba19d164ce26c3c188d
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Status changed from needs_review to needs_work
one failing doctest, because the offending lambda has been removed meanwhile
comment:4 Changed 4 years ago by
 Branch changed from u/vbraun/test_for_python_3_syntax to public/22357
 Commit changed from efff0c4593822a80695a1ba19d164ce26c3c188d to dc3c7cdb05126637ff92412a1362ed55ba573e85
 Dependencies #22354 deleted
 Status changed from needs_work to needs_review
comment:5 Changed 4 years ago by
 Commit changed from dc3c7cdb05126637ff92412a1362ed55ba573e85 to afa82c0e3ec8718ac9837921d6f25b2a8302db5c
Branch pushed to git repo; I updated commit sha1. New commits:
afa82c0  trac 22357 details

comment:6 Changed 4 years ago by
What is the use of the line
+ dirs.sort()
?
comment:7 Changed 4 years ago by
Is it intentional that this is missing a closing quote too?
print "invalid print statement
comment:8 Changed 4 years ago by
 Commit changed from afa82c0e3ec8718ac9837921d6f25b2a8302db5c to 0bb7f89295de31e3e99e43a74832af23d4eea5de
Branch pushed to git repo; I updated commit sha1. New commits:
0bb7f89  trac 22357, removed unused variable and change detail in the bad print

comment:9 Changed 4 years ago by
I made 2 small changes. Now looks good enough to me. It would be very good to have this in place, to prevent possible regressions.
comment:10 Changed 4 years ago by
 Cc tscrim jdemeyer aapitzsch added
comment:11 Changed 4 years ago by
 Reviewers set to Julian Rüth
 Status changed from needs_review to needs_work
There are some style issues. I will try to take care of them.
comment:12 Changed 4 years ago by
 Commit changed from 0bb7f89295de31e3e99e43a74832af23d4eea5de to d9ce045dbbd4edbc452d3830536a532c9c7ea8f6
comment:13 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:14 Changed 4 years ago by
 Keywords days85 added
comment:15 Changed 4 years ago by
if you add my name as author, the file must have an utf8 encoding declaration..
comment:16 Changed 4 years ago by
 Commit changed from d9ce045dbbd4edbc452d3830536a532c9c7ea8f6 to 1176203f95f7b30be2f332665f5d607b1ec87798
comment:17 Changed 4 years ago by
ok, green bot. Could please someone review this ticket ?
comment:18 Changed 4 years ago by
 Reviewers changed from Julian Rüth to Julian Rüth, Volker Braun
 Status changed from needs_review to positive_review
Feel free to add yourself to authors...
comment:19 Changed 4 years ago by
 Branch changed from public/22357 to 1176203f95f7b30be2f332665f5d607b1ec87798
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Test that sage library is (not) valid Python 3