Opened 3 years ago

Closed 3 years ago

#22352 closed enhancement (fixed)

range() -> list(xrange()) in graphs Cython files

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 45deabb (Commits) Commit: 45deabbb43235a4ae7bd13a4675be55fa404a88a
Dependencies: Stopgaps:

Description


Change History (6)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/range______list_xrange____in_graphs_cython_files

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to 45deabbb43235a4ae7bd13a4675be55fa404a88a
  • Status changed from new to needs_review

New commits:

45deabbrange(n) -> list(xrange(n)) in Cython files

comment:3 follow-up: Changed 3 years ago by chapoton

Could you elaborate on why ?

comment:4 in reply to: ↑ 3 Changed 3 years ago by jdemeyer

Replying to chapoton:

Could you elaborate on why ?

To keep the current Python 2 behaviour for range().

comment:5 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/range______list_xrange____in_graphs_cython_files to 45deabbb43235a4ae7bd13a4675be55fa404a88a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.