Opened 3 years ago

Closed 3 years ago

#22350 closed enhancement (fixed)

py3 some care for zip

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: fb4e724 (Commits) Commit: fb4e724905ce7f4cddf4329e89f63ce43cab255f
Dependencies: Stopgaps:


part of #16082

plus a few pep8 changes in the modified file

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22350
  • Commit set to 0c582441e5e9e096e0a640dcffdb573ea52d7992
  • Status changed from new to needs_review

let us wait for the bots

New commits:

bc78eaapy3 use six.iteritems in graphs
3979514trac 22331 details
1a32421trac 22331 oops, wrong import
378a334trac 22331 oops again
f01e1b3trac 22331 one detail
0c58244py3 some care for zip in plot/graphics

comment:2 Changed 3 years ago by git

  • Commit changed from 0c582441e5e9e096e0a640dcffdb573ea52d7992 to fb4e724905ce7f4cddf4329e89f63ce43cab255f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fb4e724py3 some care for zip in plot/graphics

comment:3 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch

Looks good. Positive review if bots don't complain.

comment:4 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

green bot, thanks

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22350 to fb4e724905ce7f4cddf4329e89f63ce43cab255f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.