Opened 15 years ago

Closed 10 years ago

Last modified 10 years ago

#2235 closed defect (fixed)

doctest issue -- combining # long and # 32-bit / # 64-bit

Reported by: Craig Citro Owned by: failure
Priority: minor Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: ncalexander@… Merged in: sage-5.9.beta0
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12415 Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Combining # long with # 32-bit / # 64-bit seems to completely ignore the # long directive.

There's a long doctest in sage/rings/number_field/totallyreal_rel.py that is what caused me to notice this; I've made that a # no doctest for now, because it was causing timeouts on some machines. When this bug is fixed, that needs to be changed into a # long.

Attachments (1)

2235_long_time.patch (4.0 KB) - added by Jeroen Demeyer 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 15 years ago by Craig Citro

Note: there's a long doctest in sage/rings/number_field/totallyreal_rel.py that is what caused me to notice this; I've made that a # no doctest for now, because it was causing timeouts on some machines. When this bug is fixed, that needs to be changed into a # long.

comment:2 Changed 10 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Description: modified (diff)
Report Upstream: N/A

comment:3 Changed 10 years ago by Jeroen Demeyer

Just need to add a doctest that this works now.

Changed 10 years ago by Jeroen Demeyer

Attachment: 2235_long_time.patch added

comment:4 Changed 10 years ago by Jeroen Demeyer

Status: newneeds_review

comment:5 Changed 10 years ago by Jeroen Demeyer

Dependencies: #12415

comment:6 Changed 10 years ago by David Roe

Reviewers: David Roe
Status: needs_reviewpositive_review

Looks good to me.

comment:7 Changed 10 years ago by Jeroen Demeyer

Milestone: sage-5.8sage-5.9

comment:8 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.9.beta0
Resolution: fixed
Status: positive_reviewclosed

comment:9 Changed 10 years ago by David Roe

Component: doctestdoctest framework
Note: See TracTickets for help on using tickets.