Opened 9 years ago

Closed 4 years ago

Last modified 4 years ago

#2235 closed defect (fixed)

doctest issue -- combining # long and # 32-bit / # 64-bit

Reported by: craigcitro Owned by: failure
Priority: minor Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: ncalexander@… Merged in: sage-5.9.beta0
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12415 Stopgaps:

Description (last modified by jdemeyer)

Combining # long with # 32-bit / # 64-bit seems to completely ignore the # long directive.

There's a long doctest in sage/rings/number_field/totallyreal_rel.py that is what caused me to notice this; I've made that a # no doctest for now, because it was causing timeouts on some machines. When this bug is fixed, that needs to be changed into a # long.

Attachments (1)

2235_long_time.patch (4.0 KB) - added by jdemeyer 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by craigcitro

Note: there's a long doctest in sage/rings/number_field/totallyreal_rel.py that is what caused me to notice this; I've made that a # no doctest for now, because it was causing timeouts on some machines. When this bug is fixed, that needs to be changed into a # long.

comment:2 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Report Upstream set to N/A

comment:3 Changed 4 years ago by jdemeyer

Just need to add a doctest that this works now.

Changed 4 years ago by jdemeyer

comment:4 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:5 Changed 4 years ago by jdemeyer

  • Dependencies set to #12415

comment:6 Changed 4 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks good to me.

comment:7 Changed 4 years ago by jdemeyer

  • Milestone changed from sage-5.8 to sage-5.9

comment:8 Changed 4 years ago by jdemeyer

  • Merged in set to sage-5.9.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 4 years ago by roed

  • Component changed from doctest to doctest framework
Note: See TracTickets for help on using tickets.