Opened 5 years ago

Closed 5 years ago

#22342 closed defect (fixed)

Remove superfluous quotes from bin_op exception messages

Reported by: jdemeyer Owned by:
Priority: trivial Milestone: sage-7.6
Component: coercion Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 14f4c72 (Commits, GitHub, GitLab) Commit: 14f4c72e3295257f4560ee34a3b1697ac574178d
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Replace 

TypeError: unsupported operand parent(s) for '+': ....

by 

TypeError: unsupported operand parent(s) for +: ....

to be more consistent with Python: 

>>> 1 + "foo"
TypeError: unsupported operand type(s) for +: 'int' and 'str'

Change History (7)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_superfluous_quotes_from_bin_op_exception_messages

comment:3 Changed 5 years ago by jdemeyer

  • Commit set to 14f4c72e3295257f4560ee34a3b1697ac574178d
  • Status changed from new to needs_review

New commits:

​14f4c72Remove superfluous quotes from bin_op exception messages

comment:4 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Positive review if the patchbot comes back green or you have run all of the tests.

comment:5 Changed 5 years ago by jdemeyer

I did not run all tests, so let's wait for the patchbot.

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_superfluous_quotes_from_bin_op_exception_messages to 14f4c72e3295257f4560ee34a3b1697ac574178d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.