Opened 4 years ago
Closed 4 years ago
#22325 closed enhancement (fixed)
Replace all pexpectmaxima calls in function/orthogonalpolys
Reported by:  rws  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  symbolics  Keywords:  
Cc:  Merged in:  
Authors:  Ralf Stephan  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  7a9eb46 (Commits, GitHub, GitLab)  Commit:  7a9eb46bf332b5894b27a68541e89b4616b17d8f 
Dependencies:  #22326, #22174  Stopgaps: 
Description (last modified by )
Now that some functionality of specific orthogonal polys is handled by other than pexpect calls (?, see #17753) let's replace the unneeded calls completely.
There seems to be no reason to preserve the functionality func._maxima_init_evaled_(args)
because the same can be had with maxima(func(args, hold=True))
which is also intuitive.
The ticket will also remove pexpect calls from OrthogonalPoly
.
Change History (14)
comment:1 Changed 4 years ago by
 Description modified (diff)
comment:2 Changed 4 years ago by
 Description modified (diff)
comment:3 Changed 4 years ago by
 Description modified (diff)
comment:4 Changed 4 years ago by
 Description modified (diff)
comment:5 Changed 4 years ago by
 Branch set to u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
comment:6 Changed 4 years ago by
 Commit set to 43a927b29d9648d9368e1fb77e2b580e0a3cb94c
 Dependencies set to #22326
comment:7 Changed 4 years ago by
 Commit changed from 43a927b29d9648d9368e1fb77e2b580e0a3cb94c to bf11e48fe353f3fe3ad4cfe35235bda1433952c8
Branch pushed to git repo; I updated commit sha1. New commits:
76ed92e  Merge branch 'develop' into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys

648e498  22174: Interface expression conversion to gamma() and normalization

e82d2d2  Merge branch 'u/rws/interface_expression_conversion_to_gamma___and_normalization' of git://trac.sagemath.org/sage into t/22326/jacobi_p_polynomials_without_pexpect_maxima

445931a  22326: native symbolic jacobi_P

164d709  22326: fixes

e0bb9cf  Merge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys

bf11e48  22325: finally remove _init()

comment:8 Changed 4 years ago by
 Dependencies changed from #22326 to #22326, #22174
 Status changed from new to needs_review
comment:9 followup: ↓ 10 Changed 4 years ago by
I am not sure about this change:

src/sage/functions/orthogonal_polys.py
diff git a/src/sage/functions/orthogonal_polys.py b/src/sage/functions/orthogonal_polys.py index 1421a53..a6fe651 100644
a b class OrthogonalFunction(BuiltinFunction): 465 412 return self.eval_pari(*args, **kwds) 466 413 elif algorithm == 'recursive': 467 414 return self.eval_recursive(*args, **kwds) 468 elif algorithm == 'maxima':469 return self._maxima_init_evaled_(*args, **kwds)470 415 471 416 return super(OrthogonalFunction,self).__call__(*args, **kwds) 472 417
as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the algorithm='maxima'
input or (IMO better) send it off to Maxima.
comment:10 in reply to: ↑ 9 Changed 4 years ago by
Replying to tscrim:
as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the
algorithm='maxima'
input or (IMO better) send it off to Maxima.
Right, I intended delegating but did the wrong thing.
comment:11 Changed 4 years ago by
 Commit changed from bf11e48fe353f3fe3ad4cfe35235bda1433952c8 to 7a9eb46bf332b5894b27a68541e89b4616b17d8f
Branch pushed to git repo; I updated commit sha1. New commits:
1c7b67e  22326: cosmetics

e04186d  Merge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys

7a9eb46  22325: preserve algorithm='maxima', add doctests

comment:12 Changed 4 years ago by
Actually that never worked. Let's open a ticket for it.
comment:13 Changed 4 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Thanks. I agree; we can handle the algorithm issues on a followup.
comment:14 Changed 4 years ago by
 Branch changed from u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys to 7a9eb46bf332b5894b27a68541e89b4616b17d8f
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
22325: remove all _maxima_init_evaled_; move doctests to _init_