Opened 3 years ago

Closed 3 years ago

#22325 closed enhancement (fixed)

Replace all pexpect-maxima calls in function/orthogonal-polys

Reported by: rws Owned by:
Priority: major Milestone: sage-7.6
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7a9eb46 (Commits) Commit: 7a9eb46bf332b5894b27a68541e89b4616b17d8f
Dependencies: #22326, #22174 Stopgaps:

Description (last modified by rws)

Now that some functionality of specific orthogonal polys is handled by other than pexpect calls (?, see #17753) let's replace the unneeded calls completely.

There seems to be no reason to preserve the functionality func._maxima_init_evaled_(args) because the same can be had with maxima(func(args, hold=True)) which is also intuitive.

The ticket will also remove pexpect calls from OrthogonalPoly.

Change History (14)

comment:1 Changed 3 years ago by rws

  • Description modified (diff)

comment:2 Changed 3 years ago by rws

  • Description modified (diff)

comment:3 Changed 3 years ago by rws

  • Description modified (diff)

comment:4 Changed 3 years ago by rws

  • Description modified (diff)

comment:5 Changed 3 years ago by rws

  • Branch set to u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys

comment:6 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 43a927b29d9648d9368e1fb77e2b580e0a3cb94c
  • Dependencies set to #22326

New commits:

43a927b22325: remove all _maxima_init_evaled_; move doctests to _init_

comment:7 Changed 3 years ago by git

  • Commit changed from 43a927b29d9648d9368e1fb77e2b580e0a3cb94c to bf11e48fe353f3fe3ad4cfe35235bda1433952c8

Branch pushed to git repo; I updated commit sha1. New commits:

76ed92eMerge branch 'develop' into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
648e49822174: Interface expression conversion to gamma() and normalization
e82d2d2Merge branch 'u/rws/interface_expression_conversion_to_gamma___and_normalization' of git://trac.sagemath.org/sage into t/22326/jacobi_p_polynomials_without_pexpect_maxima
445931a22326: native symbolic jacobi_P
164d70922326: fixes
e0bb9cfMerge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
bf11e4822325: finally remove _init()

comment:8 Changed 3 years ago by rws

  • Dependencies changed from #22326 to #22326, #22174
  • Status changed from new to needs_review

comment:9 follow-up: Changed 3 years ago by tscrim

I am not sure about this change:

  • src/sage/functions/orthogonal_polys.py

    diff --git a/src/sage/functions/orthogonal_polys.py b/src/sage/functions/orthogonal_polys.py
    index 1421a53..a6fe651 100644
    a b class OrthogonalFunction(BuiltinFunction): 
    465412            return self.eval_pari(*args, **kwds)
    466413        elif algorithm == 'recursive':
    467414            return self.eval_recursive(*args, **kwds)
    468         elif algorithm == 'maxima':
    469             return self._maxima_init_evaled_(*args, **kwds)
    470415
    471416        return super(OrthogonalFunction,self).__call__(*args, **kwds)
    472417

as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the algorithm='maxima' input or (IMO better) send it off to Maxima.

comment:10 in reply to: ↑ 9 Changed 3 years ago by rws

Replying to tscrim:

as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the algorithm='maxima' input or (IMO better) send it off to Maxima.

Right, I intended delegating but did the wrong thing.

comment:11 Changed 3 years ago by git

  • Commit changed from bf11e48fe353f3fe3ad4cfe35235bda1433952c8 to 7a9eb46bf332b5894b27a68541e89b4616b17d8f

Branch pushed to git repo; I updated commit sha1. New commits:

1c7b67e22326: cosmetics
e04186dMerge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
7a9eb4622325: preserve algorithm='maxima', add doctests

comment:12 Changed 3 years ago by rws

Actually that never worked. Let's open a ticket for it.

comment:13 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks. I agree; we can handle the algorithm issues on a followup.

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys to 7a9eb46bf332b5894b27a68541e89b4616b17d8f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.