Opened 6 years ago

Closed 6 years ago

#22320 closed enhancement (fixed)

py3: some care for range

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Travis Scrimshaw, Jeroen Demeyer, aapitzsch, Jori Mäntysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 63fb338 (Commits, GitHub, GitLab) Commit: 63fb338653bddb4a508b71ccbd375cbe2f861d40
Dependencies: Stopgaps:

Status badges

Description

preparing for transition to py3: handle some problems with range

found using the test branch at #16081

Change History (6)

comment:1 Changed 6 years ago by Frédéric Chapoton

Branch: u/chapoton/22230
Commit: 8cb5cc079979169a6f910f4a04d76271976b4134

New commits:

8cb5cc0py3: some care for range

comment:2 Changed 6 years ago by Frédéric Chapoton

Branch: u/chapoton/22230u/chapoton/22320
Commit: 8cb5cc079979169a6f910f4a04d76271976b413463fb338653bddb4a508b71ccbd375cbe2f861d40

comment:3 Changed 6 years ago by Frédéric Chapoton

Cc: Travis Scrimshaw Jeroen Demeyer aapitzsch Jori Mäntysalo added
Status: newneeds_review

green bot, please review

comment:4 Changed 6 years ago by Jori Mäntysalo

Reviewers: Jori Mäntysalo

comment:5 Changed 6 years ago by Jori Mäntysalo

Status: needs_reviewpositive_review

OK.

Actually poset contructor can take an iterator like Poset((xrange(4), [])), so the first modification is not strictly necessary.

comment:6 Changed 6 years ago by Volker Braun

Branch: u/chapoton/2232063fb338653bddb4a508b71ccbd375cbe2f861d40
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.