Opened 3 years ago
Closed 3 years ago
#22298 closed enhancement (fixed)
py3 : no .iteritems in combinat/
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  python3  Keywords:  
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Jori Mäntysalo 
Report Upstream:  N/A  Work issues:  
Branch:  4802315 (Commits)  Commit:  4802315e8a29e751ba3cc05edec770573a61db6a 
Dependencies:  Stopgaps: 
Description
as a step to python3
use the six.iteritems instead, here just in combinat/
change done using the script "iteritems" from "sixer"
https://github.com/haypo/sixer
part of #15981
Change History (10)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/22298
 Commit set to 8fe2a8a3f50915dbf1d0cb6c052d0ec4ce33f123
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Commit changed from 8fe2a8a3f50915dbf1d0cb6c052d0ec4ce33f123 to f590c6759439d4132a781cb86215538a9e75c7e2
Branch pushed to git repo; I updated commit sha1. New commits:
f590c67  trac 2229_ manual fixing for .iteritems removal in combinat

comment:3 Changed 3 years ago by
What about
elt = dict({ x for x in dict(HLP(m(la))).iteritems() if x[0] in self._kbounded_partitions })
in src/sage/combinat/sf/k_dual.py
?
I can review this one.
comment:4 Changed 3 years ago by
 Reviewers set to Jori Mäntysalo
Seems to be OK and tests passed. Feel free to mark as positive_review now, of check src/sage/combinat/sf/k_dual.py
, whichever you want.
comment:5 Changed 3 years ago by
 Commit changed from f590c6759439d4132a781cb86215538a9e75c7e2 to d8a6c8dcaea6dfe8c7f153abeeb84fadf63c5d02
Branch pushed to git repo; I updated commit sha1. New commits:
d8a6c8d  trac 22298 fixing 2 missing cases of iteritems in combinat

comment:6 Changed 3 years ago by
Thank you, Jori.
I have found another missing case, and treated it too.
comment:7 Changed 3 years ago by
 Status changed from needs_review to needs_work
Typo: parenthesis at the end of
for (nn,lmbda,mu,uu),(kk,f) in iteritems(QDM[n,1]))
comment:8 Changed 3 years ago by
 Commit changed from d8a6c8dcaea6dfe8c7f153abeeb84fadf63c5d02 to 4802315e8a29e751ba3cc05edec770573a61db6a
Branch pushed to git repo; I updated commit sha1. New commits:
4802315  trac 22298 syntax error

comment:10 Changed 3 years ago by
 Branch changed from u/chapoton/22298 to 4802315e8a29e751ba3cc05edec770573a61db6a
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
py3: get rid of .iteritems in combinat folder