Opened 4 years ago

Closed 4 years ago

#22282 closed enhancement (fixed)

py3 remove cmp() in another btquotient file

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: jdemeyer, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 68f814e (Commits, GitHub, GitLab) Commit: 68f814e6ce00b0c8f525f95dcf65603f68efc715
Dependencies: Stopgaps:

Status badges

Description

as a step to py3

Change History (11)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22282
  • Commit set to 5680ad394f559169626ddcb8005e76d6bb30f17f

New commits:

5680ad3py3 : removal of some calls cmp() in another btquotient file

comment:2 Changed 4 years ago by git

  • Commit changed from 5680ad394f559169626ddcb8005e76d6bb30f17f to 36219bdb863c74315666d6e4bdfd1bc556ea050a

Branch pushed to git repo; I updated commit sha1. New commits:

36219bdtrac 22282 second try at removing calls to cmp(), not yet fully ok

comment:3 Changed 4 years ago by git

  • Commit changed from 36219bdb863c74315666d6e4bdfd1bc556ea050a to f7ee8a5393d5ba39ea35f173901bec53cbba6506

Branch pushed to git repo; I updated commit sha1. New commits:

f7ee8a5trac 22282 some details

comment:4 Changed 4 years ago by chapoton

There now seems to remain 2 failures about comparison to 0. Maybe there lacks a __bool__ method ?

comment:5 Changed 4 years ago by git

  • Commit changed from f7ee8a5393d5ba39ea35f173901bec53cbba6506 to 24c88534cbb048c1820ad443b7b633745660fcb6

Branch pushed to git repo; I updated commit sha1. New commits:

24c8853trac 22282 remove cmp, now correct richcmp

comment:6 Changed 4 years ago by chapoton

  • Cc jdemeyer tscrim added
  • Status changed from new to needs_review

bot failure seems unrelated, please review

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Nitpick:

-        - ``other`` - a BruhatTitsHarmonicCocycles class.
+        - ``other`` -- a BruhatTitsHarmonicCocycles class
-        - ``other`` - another space of `p`-automorphic forms.
+        - ``other`` -- another space of `p`-automorphic forms

Otherwise LGTM.

Last edited 4 years ago by tscrim (previous) (diff)

comment:8 Changed 4 years ago by git

  • Commit changed from 24c88534cbb048c1820ad443b7b633745660fcb6 to 68f814e6ce00b0c8f525f95dcf65603f68efc715

Branch pushed to git repo; I updated commit sha1. New commits:

1cc05e8Merge branch 'u/chapoton/22282' in 7.6.b2
68f814etrac 22282 details

comment:9 Changed 4 years ago by chapoton

done (in a minimal way)

comment:10 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

periods as well...but I nitpicked enough for this one...

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/22282 to 68f814e6ce00b0c8f525f95dcf65603f68efc715
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.