Opened 6 years ago

Closed 6 years ago

#22276 closed defect (fixed)

Fix and add PARI patches

Reported by: Jeroen Demeyer Owned by:
Priority: blocker Milestone: sage-7.6
Component: packages: standard Keywords:
Cc: Luca De Feo, Vincent Delecroix, Peter Bruin Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: a70bf47 (Commits, GitHub, GitLab) Commit: a70bf47d75dbcdd6697b8fd78a823cfc7ac4dd67
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

  • prot_none.patch: add two fixes which were added upstream (one of them fixing a serious bug in gp)
  • get_config_options.patch: replace with a variant which was accepted upstream and rename to config_graphic.patch
  • ensure that all patches apply without fuzz.

Change History (11)

comment:1 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/fix_pari_patches

comment:3 Changed 6 years ago by Jeroen Demeyer

Commit: 83083603dc306662eb2f21238a5b0cfd1bc48dba
Status: newneeds_review

New commits:

8308360Fix PARI patches

comment:4 Changed 6 years ago by Jeroen Demeyer

Cc: Luca De Feo Vincent Delecroix Peter Bruin added
Description: modified (diff)

comment:5 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)
Status: needs_reviewneeds_work

comment:6 Changed 6 years ago by git

Commit: 83083603dc306662eb2f21238a5b0cfd1bc48dbaf4654db9b3084fd14e79a7c257a3a5806828d900

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f4654dbFix and add PARI patches

comment:7 Changed 6 years ago by Jeroen Demeyer

Status: needs_workneeds_review
Summary: Fix PARI patchesFix and add PARI patches

comment:8 Changed 6 years ago by git

Commit: f4654db9b3084fd14e79a7c257a3a5806828d900a70bf47d75dbcdd6697b8fd78a823cfc7ac4dd67

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a70bf47Fix and add PARI patches

comment:9 Changed 6 years ago by Peter Bruin

Reviewers: Peter Bruin

comment:10 Changed 6 years ago by Peter Bruin

Status: needs_reviewpositive_review

Looks good and passes doctests. After the next PARI upgrade, get_dlcflags.patch and stackwarn.patch should be the only patches left.

comment:11 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/fix_pari_patchesa70bf47d75dbcdd6697b8fd78a823cfc7ac4dd67
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.