Opened 5 years ago

Closed 4 years ago

#22275 closed enhancement (fixed)

Implement duality of faces for reflexive polytopes

Reported by: novoselt Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords:
Cc: saraedum Merged in:
Authors: Andrey Novoseltsev Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 4109827 (Commits, GitHub, GitLab) Commit: 410982781a1596eb44a3de079ccbec4786b00d9f
Dependencies: #22122 Stopgaps:

Status badges

Description

It was "secretly" implemented in the old code removed in #22122 by order of faces and while it was not documented in Sage, it was dissipated in some worksheets and papers.

Change History (7)

comment:1 Changed 5 years ago by novoselt

  • Branch set to u/novoselt/22275

comment:2 Changed 5 years ago by novoselt

  • Cc saraedum added
  • Commit set to 77616f81cdd1a4937d08c5d01dec4906d0fca917
  • Status changed from new to needs_review

Julian, can you take a look at a short follow up for #22122?


New commits:

4599dccRemove old-style faces of lattice polytopes
5c97bbdMerge #22122 into #22275
77616f8Implement duality of faces for reflexive polytopes

comment:3 Changed 5 years ago by git

  • Commit changed from 77616f81cdd1a4937d08c5d01dec4906d0fca917 to 410982781a1596eb44a3de079ccbec4786b00d9f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4109827Implement duality of faces for reflexive polytopes

comment:4 Changed 5 years ago by novoselt

Managed to miss blank line somehow.

comment:5 Changed 5 years ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

comment:6 Changed 5 years ago by novoselt

Thank you!

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/novoselt/22275 to 410982781a1596eb44a3de079ccbec4786b00d9f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.