Opened 6 years ago

Closed 6 years ago

#22251 closed defect (fixed)

Fix lie_polynomial

Reported by: tscrim Owned by:
Priority: major Milestone: sage-7.6
Component: algebra Keywords:
Cc: Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2821a90 (Commits, GitHub, GitLab) Commit: 2821a9002e60ea7a5fef1157d348d201b5c1a670
Dependencies: Stopgaps:

Status badges

Description

We currently have 

sage: F = FreeAlgebra(QQ, 3, 'x,y,z') 
sage: M.<x,y,z> = FreeMonoid(3)
sage: F.lie_polynomial(w)
x*y*z - y*z*x

and instead should result in: 

x*y*z - x*z*y - y*z*x + z*y*x

Change History (9)

comment:1 Changed 6 years ago by tscrim

  • Branch set to public/algebras/fix_lie_polynomial-22251
  • Commit set to 30697fc759acedfd889052727687ff1e27e534d4
  • Status changed from new to needs_review

New commits:

​30697fcMaking Lie polynomial recursive to match the definition.

comment:2 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

looks good to me, provided the patchbot turns green.

comment:3 Changed 6 years ago by chapoton

  • Status changed from positive_review to needs_work

I have just noticed a strange line in the reference file: 

S\. Murphy, M\. Robshaw

could you correct that by passing ?

comment:4 Changed 6 years ago by git

  • Commit changed from 30697fc759acedfd889052727687ff1e27e534d4 to 335c830d49899a04cf250748a8358f5db7c9127f

Branch pushed to git repo; I updated commit sha1. New commits:

​335c830Little (adjacent) details.

comment:5 Changed 6 years ago by tscrim

  • Status changed from needs_work to positive_review

Done.

comment:6 Changed 6 years ago by chapoton

  • Status changed from positive_review to needs_work

one failing doctest

comment:7 Changed 6 years ago by git

  • Commit changed from 335c830d49899a04cf250748a8358f5db7c9127f to 2821a9002e60ea7a5fef1157d348d201b5c1a670

Branch pushed to git repo; I updated commit sha1. New commits:

​0ef0543Merge branch 'public/algebras/fix_lie_polynomial-22251' of git://trac.sagemath.org/sage into public/algebras/fix_lie_polynomial-22251
​2821a90Fixing last doctest.

comment:8 Changed 6 years ago by tscrim

  • Status changed from needs_work to positive_review

Fixed.

comment:9 Changed 6 years ago by vbraun

  • Branch changed from public/algebras/fix_lie_polynomial-22251 to 2821a9002e60ea7a5fef1157d348d201b5c1a670
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.