Opened 6 years ago

Last modified 4 years ago

#22250 needs_info defect

performance-fixup: powers of 1 in QQbar

Reported by: Daniel Krenn Owned by:
Priority: major Milestone: sage-7.6
Component: algebra Keywords:
Cc: Vincent Delecroix, Clemens Heuberger, Benjamin Hackl Merged in:
Authors: Daniel Krenn Reviewers:
Report Upstream: N/A Work issues: merge conflicts, re-evaluation of purpose
Branch: u/dkrenn/qqbar-power-1-better (Commits, GitHub, GitLab) Commit: bf67f85f73b9caa01600bff4511b4a0ba584e0fa
Dependencies: #22120 Stopgaps:

Status badges

Description

#22120 introduced a significant slowdown of

sage: s = sum(AA(i)**(1/i) for i in range(1,20))
sage: (s/s) ** 4

The aim of this ticket is to repair this. See also the comments on #22120.

Change History (9)

comment:1 Changed 6 years ago by Daniel Krenn

Branch: u/dkrenn/qqbar-power-1-better

comment:2 Changed 6 years ago by Vincent Delecroix

Cc: Vincent Delecroix added
Commit: 48ff5daf63a0376d65d32b7d5ce4069cc852b214

New commits:

3804d83Merge tag '7.5' into t/22120/064f5525ddfddbdd61611e6d3b604cf41bc54424
6acdb6atest for trivially one in __pow__
79862d6new code for AA
48ff5dadoctest the new behavior

comment:3 Changed 6 years ago by git

Commit: 48ff5daf63a0376d65d32b7d5ce4069cc852b214bf67f85f73b9caa01600bff4511b4a0ba584e0fa

Branch pushed to git repo; I updated commit sha1. New commits:

bf67f85remove doctest as it will not finish

comment:4 in reply to:  description Changed 6 years ago by Daniel Krenn

Status: newneeds_review

Replying to dkrenn:

#22120 introduced a significant slowdown of

sage: s = sum(AA(i)**(1/i) for i in range(1,20))
sage: (s/s) ** 4

The aim of this ticket is to repair this. See also the comments on #22120.

Problem fixed, but the above example seems to have failed before (see also the discussion on #22120.)

comment:5 Changed 6 years ago by Daniel Krenn

Cc: Clemens Heuberger Benjamin Hackl added

comment:6 Changed 5 years ago by Julian Rüth

Work issues: merge conflicts

comment:7 Changed 5 years ago by Julian Rüth

Status: needs_reviewneeds_work

comment:8 Changed 4 years ago by Daniel Krenn

Status: needs_workneeds_info

There is more going on than a simple merge conflict. See also #24490 and the current (8.6) code has changed completely (by some other ticket whose number I didn't find).

comment:9 Changed 4 years ago by Daniel Krenn

Work issues: merge conflictsmerge conflicts, re-evaluation of purpose
Note: See TracTickets for help on using tickets.