Opened 6 years ago
Closed 6 years ago
#22240 closed enhancement (fixed)
Use relative imports in sage_setup/autogen/pari
Reported by:  Jeroen Demeyer  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  build  Keywords:  
Cc:  Luca De Feo, Vincent Delecroix  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  e98c90b (Commits, GitHub, GitLab)  Commit:  e98c90b0ce51ba75d8d15aecb6e64149912f1c14 
Dependencies:  #20729  Stopgaps: 
Description
Change History (7)
comment:1 Changed 6 years ago by
Branch:  → u/jdemeyer/use_relative_imports_in_sage_setup_autogen_pari 

comment:2 Changed 6 years ago by
Commit:  → e1c1c04a263295cbb6d4b482d22d1f99a5a8dcd4 

Dependencies:  → #20729 
comment:3 Changed 6 years ago by
Commit:  e1c1c04a263295cbb6d4b482d22d1f99a5a8dcd4 → e98c90b0ce51ba75d8d15aecb6e64149912f1c14 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
13d4a62  Doctesting: never import files which are part of a package

818e71b  Merge commit '13d4a62814d5048884553385412b4285f3fa5fbd' into t/22240/use_relative_imports_in_sage_setup_autogen_pari

e98c90b  Use relative imports in sage_setup/autogen/pari

comment:4 Changed 6 years ago by
Status:  new → needs_review 

comment:5 followup: 6 Changed 6 years ago by
Reviewers:  → Vincent Delecroix 

Status:  needs_review → positive_review 
works fine (and already in the cypari2 repo on github by Luca)
comment:6 Changed 6 years ago by
Replying to vdelecroix:
already in the cypari2 repo on github by Luca
I know, I made this ticket because I saw a similar change in Luca's repo.
comment:7 Changed 6 years ago by
Branch:  u/jdemeyer/use_relative_imports_in_sage_setup_autogen_pari → e98c90b0ce51ba75d8d15aecb6e64149912f1c14 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
Use relative imports in sage_setup/autogen/pari