Opened 6 years ago

Closed 6 years ago

#22240 closed enhancement (fixed)

Use relative imports in sage_setup/autogen/pari

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.6
Component: build Keywords:
Cc: Luca De Feo, Vincent Delecroix Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: e98c90b (Commits, GitHub, GitLab) Commit: e98c90b0ce51ba75d8d15aecb6e64149912f1c14
Dependencies: #20729 Stopgaps:

Status badges


Change History (7)

comment:1 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/use_relative_imports_in_sage_setup_autogen_pari

comment:2 Changed 6 years ago by Jeroen Demeyer

Commit: e1c1c04a263295cbb6d4b482d22d1f99a5a8dcd4
Dependencies: #20729

New commits:

e1c1c04Use relative imports in sage_setup/autogen/pari

comment:3 Changed 6 years ago by git

Commit: e1c1c04a263295cbb6d4b482d22d1f99a5a8dcd4e98c90b0ce51ba75d8d15aecb6e64149912f1c14

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

13d4a62Doctesting: never import files which are part of a package
818e71bMerge commit '13d4a62814d5048884553385412b4285f3fa5fbd' into t/22240/use_relative_imports_in_sage_setup_autogen_pari
e98c90bUse relative imports in sage_setup/autogen/pari

comment:4 Changed 6 years ago by Jeroen Demeyer

Status: newneeds_review

comment:5 Changed 6 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

works fine (and already in the cypari2 repo on github by Luca)

comment:6 in reply to:  5 Changed 6 years ago by Jeroen Demeyer

Replying to vdelecroix:

already in the cypari2 repo on github by Luca

I know, I made this ticket because I saw a similar change in Luca's repo.

comment:7 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/use_relative_imports_in_sage_setup_autogen_parie98c90b0ce51ba75d8d15aecb6e64149912f1c14
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.