Opened 6 years ago

Closed 6 years ago

#22221 closed defect (fixed)

Fix dependency on PARI headers

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.6
Component: interfaces Keywords:
Cc: Luca De Feo, Vincent Delecroix Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 41d47f7 (Commits, GitHub, GitLab) Commit: 41d47f7a14d9844c3a030c234a2c5d4a8971944f
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

cypari2 includes the header file <pari/pari.h> indirectly through a custom cypari.h header. This is bad for Cython's dependency checking as Cython doesn't know that cypari.h depends on <pari/pari.h>.

Change History (7)

comment:1 Changed 6 years ago by Jeroen Demeyer

Cc: Luca De Feo Vincent Delecroix added

comment:2 Changed 6 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Description: modified (diff)

comment:3 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/fix_dependency_on_pari_headers

comment:4 Changed 6 years ago by Jeroen Demeyer

Commit: 41d47f7a14d9844c3a030c234a2c5d4a8971944f
Status: newneeds_review

New commits:

41d47f7Fix dependency on PARI headers

comment:5 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:6 Changed 6 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

comment:7 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/fix_dependency_on_pari_headers41d47f7a14d9844c3a030c234a2c5d4a8971944f
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.