Opened 2 years ago

Closed 2 years ago

#22220 closed defect (fixed)

Remove instance of SAGE_SRC from sage runtime introduced by #20745

Reported by: fbissey Owned by:
Priority: blocker Milestone: sage-7.6
Component: distribution Keywords:
Cc: Merged in:
Authors: François Bissey Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 6103dcb (Commits) Commit: 6103dcbfd70c0431ed6f902359aceb8c2d8496bf
Dependencies: Stopgaps:

Description

Ticket #20745 introduced instances of SAGE_SRC to be used at runtime in sage/homology/simplicial_set_examples.py. The data that is queried is properly installed in SAGE_EXTCODE so that doesn't need to be corrected. as well.

This is of course a no-no especially for sage-on-distro.

Change History (3)

comment:1 Changed 2 years ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/sage_src_elimination
  • Commit set to 6103dcbfd70c0431ed6f902359aceb8c2d8496bf
  • Status changed from new to needs_review

Last 10 new commits:

4f2e6fdsimplicial sets: improve the 'image' method for morphisms.
341ed16simplicial sets: less verbose printing of simplices
eabd3f8Simplicial sets: define _latex_ method more widely and use it in Nerve
603a3cfSimplicial sets: use WithEqualityById instead of UniqueRepresentation
e1ae3f2Merge branch 'develop' into t/20745/simplicial_sets
600157dSimplicial sets: add _latex_ methods to the constructions.
3147f18Merge branch 'develop' into t/20745/simplicial_sets
6f01bdatrac 20745: some rewordings of docstrings and comments,
35790d2trac 20745: fix bug with product of a point with itself
6103dcbUse installed version of Kenso files rather than the source one at runtime.

comment:2 Changed 2 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/fbissey/sage_src_elimination to 6103dcbfd70c0431ed6f902359aceb8c2d8496bf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.