Opened 6 years ago
Closed 6 years ago
#22212 closed enhancement (fixed)
Improve method PowerSeries._pari_()
Reported by: | pbruin | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.6 |
Component: | interfaces | Keywords: | |
Cc: | Merged in: | ||
Authors: | Peter Bruin | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 4ed448f (Commits, GitHub, GitLab) | Commit: | 4ed448f51a9678f2d702196bc022913482424a20 |
Dependencies: | #22216 | Stopgaps: |
Description (last modified by )
A minor improvement split off from #15601. This makes the method PowerSeries._pari_()
slightly more efficient, and also makes it accept power series with infinite precision (by converting them to PARI t_POL
instead of t_SER
).
Change History (7)
comment:1 Changed 6 years ago by
- Branch set to u/pbruin/22212-PowerSeries_to_pari
- Commit set to 4ed448f51a9678f2d702196bc022913482424a20
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Dependencies set to #22216
comment:3 Changed 6 years ago by
- Description modified (diff)
comment:4 follow-up: ↓ 5 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 6 years ago by
- Status changed from needs_review to positive_review
Replying to tscrim:
If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.
Thanks. In PARI, polynomials and power series can be mixed easily, just like in Sage polynomial rings coerce into power series rings. In fact, power series with infinite precision are implemented in #15601 using PARI polynomials.
comment:6 in reply to: ↑ 5 Changed 6 years ago by
Replying to pbruin:
Replying to tscrim:
If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.
Thanks. In PARI, polynomials and power series can be mixed easily, just like in Sage polynomial rings coerce into power series rings. In fact, power series with infinite precision are implemented in #15601 using PARI polynomials.
Thank you for the explanation. That is what I was thinking, but it is good to have confirmation.
comment:7 Changed 6 years ago by
- Branch changed from u/pbruin/22212-PowerSeries_to_pari to 4ed448f51a9678f2d702196bc022913482424a20
- Resolution set to fixed
- Status changed from positive_review to closed
If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.