Opened 6 years ago

Closed 6 years ago

#22209 closed enhancement (fixed)

Differentiation of conj/imag/real/abs functions

Reported by: Ralf Stephan Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 052e3cb (Commits, GitHub, GitLab) Commit: 052e3cb82cbb06a8fcaae7e5b949d8d34504b663
Dependencies: #22219 Stopgaps:

Status badges

Description (last modified by Ralf Stephan)

At the moment the result from differentiation of the functions conj, real, imag, abs does not take the argument domain into account.

sage: _ = var('x', domain='real')
sage: _ = var('z')

sage: (x^z).conjugate().diff(x)
x^(z - 1)*z*D[0](conjugate)(x^z)
sage: atan(x).imag_part().diff(x)
D[0](imag_part)(arctan(x))/(x^2 + 1)
sage: abs(log(z)).diff(z)
log(z)/(z*abs(log(z)))

GiNaC has functionality that is only now included in Pynac. The ticket should doctest it when it is implemented. It all benefits from recent domain logic improvements in Pynac as well.

https://github.com/pynac/pynac/issues/45

Change History (8)

comment:1 Changed 6 years ago by Ralf Stephan

Description: modified (diff)

comment:2 Changed 6 years ago by Ralf Stephan

Branch: u/rws/differentiation_of_conj_imag_real_abs_functions

comment:3 Changed 6 years ago by Ralf Stephan

Authors: Ralf Stephan
Commit: f96fe12adb044d5ec132f2ca26c15dd09f43d9c1
Dependencies: pynac-0.7.4
Description: modified (diff)
Status: newneeds_review

New commits:

f96fe1222209: Differentiation of conj/imag/real/abs functions

comment:4 Changed 6 years ago by Ralf Stephan

Dependencies: pynac-0.7.4#22219
Status: needs_reviewneeds_work

comment:5 Changed 6 years ago by Ralf Stephan

Status: needs_workneeds_review

Trigger patchbot.

comment:6 Changed 6 years ago by git

Commit: f96fe12adb044d5ec132f2ca26c15dd09f43d9c1052e3cb82cbb06a8fcaae7e5b949d8d34504b663

Branch pushed to git repo; I updated commit sha1. New commits:

052e3cbMerge branch 'develop' into t/22209/differentiation_of_conj_imag_real_abs_functions

comment:7 Changed 6 years ago by Travis Scrimshaw

Milestone: sage-7.6sage-8.0
Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:8 Changed 6 years ago by Volker Braun

Branch: u/rws/differentiation_of_conj_imag_real_abs_functions052e3cb82cbb06a8fcaae7e5b949d8d34504b663
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.