Opened 2 years ago

Closed 2 years ago

#22209 closed enhancement (fixed)

Differentiation of conj/imag/real/abs functions

Reported by: rws Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 052e3cb (Commits) Commit: 052e3cb82cbb06a8fcaae7e5b949d8d34504b663
Dependencies: #22219 Stopgaps:

Description (last modified by rws)

At the moment the result from differentiation of the functions conj, real, imag, abs does not take the argument domain into account.

sage: _ = var('x', domain='real')
sage: _ = var('z')

sage: (x^z).conjugate().diff(x)
x^(z - 1)*z*D[0](conjugate)(x^z)
sage: atan(x).imag_part().diff(x)
D[0](imag_part)(arctan(x))/(x^2 + 1)
sage: abs(log(z)).diff(z)
log(z)/(z*abs(log(z)))

GiNaC has functionality that is only now included in Pynac. The ticket should doctest it when it is implemented. It all benefits from recent domain logic improvements in Pynac as well.

https://github.com/pynac/pynac/issues/45

Change History (8)

comment:1 Changed 2 years ago by rws

  • Description modified (diff)

comment:2 Changed 2 years ago by rws

  • Branch set to u/rws/differentiation_of_conj_imag_real_abs_functions

comment:3 Changed 2 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to f96fe12adb044d5ec132f2ca26c15dd09f43d9c1
  • Dependencies set to pynac-0.7.4
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

f96fe1222209: Differentiation of conj/imag/real/abs functions

comment:4 Changed 2 years ago by rws

  • Dependencies changed from pynac-0.7.4 to #22219
  • Status changed from needs_review to needs_work

comment:5 Changed 2 years ago by rws

  • Status changed from needs_work to needs_review

Trigger patchbot.

comment:6 Changed 2 years ago by git

  • Commit changed from f96fe12adb044d5ec132f2ca26c15dd09f43d9c1 to 052e3cb82cbb06a8fcaae7e5b949d8d34504b663

Branch pushed to git repo; I updated commit sha1. New commits:

052e3cbMerge branch 'develop' into t/22209/differentiation_of_conj_imag_real_abs_functions

comment:7 Changed 2 years ago by tscrim

  • Milestone changed from sage-7.6 to sage-8.0
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/rws/differentiation_of_conj_imag_real_abs_functions to 052e3cb82cbb06a8fcaae7e5b949d8d34504b663
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.