Changes between Initial Version and Version 1 of Ticket #22191, comment 96


Ignore:
Timestamp:
01/07/19 13:46:11 (17 months ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22191, comment 96

    initial v1  
    33It's not clear to me or well documented how feenable/disableexcept interact with fesetenv.  Presumably the latter should encompass the former, but I have not looked into it in more detail.  I agree that the get/setenv functions look better overall and more portable.
    44
    5 So for now I'd be more comfortable just doing exactly the converse to what ECL is doing.  In this code I use `fedisableexcept(FE_ALL_EXCEPT)` to just disable all floating point exceptions, followed by `feenableexcept(...)` for just the ECL flags, or just the Sage flags (which should be 0, since I'm not aware of anything in Sage or any of its other dependencies that, at least by default, set's FPE traps, but we save/restore it anyways just in case).
     5So for now I'd be more comfortable just doing exactly the converse to what ECL is doing.  In this code I use `fedisableexcept(FE_ALL_EXCEPT)` to just disable all floating point exceptions, followed by `feenableexcept(...)` for just the ECL flags, or just the Sage flags (which should be 0, since I'm not aware of anything in Sage or any of its other dependencies that, at least by default, sets FPE traps, but we save/restore it anyways just in case).