Opened 6 years ago

Closed 5 years ago

#22187 closed enhancement (fixed)

Bounded affine permutation of a matrix

Reported by: rkarpman Owned by:
Priority: major Milestone: sage-8.0
Component: combinatorics Keywords: days82, bounded affine permutation, decorated permutation, positroid
Cc: egunawan, vivianepons, jessicapalencia Merged in:
Authors: Rachel Karpman Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8862fa1 (Commits, GitHub, GitLab) Commit: 8862fa12d4f1c008588cf8cc2eeb4043dfd8cf8b
Dependencies: Stopgaps:

Status badges

Description (last modified by tscrim)

Added a method bounded_affine_permutation to permutation, which outputs a partial permutation representing the bounded affine permutation of a real matrix.

Change History (10)

comment:1 Changed 6 years ago by rkarpman

  • Branch set to u/rkarpman/22187bdd_affine
  • Commit set to 5ff1792b2c070d5cdf996bced66afc4f1afcf33d
  • Status changed from new to needs_review

New commits:

5ff1792inital commit for adding bdd_affine_perm method in permutation

comment:2 Changed 6 years ago by git

  • Commit changed from 5ff1792b2c070d5cdf996bced66afc4f1afcf33d to 80381a4d7d319c39f290965f225581bbe31dd44c

Branch pushed to git repo; I updated commit sha1. New commits:

80381a4Added citation for KLS2013 to index, updated reference in permutation

comment:3 Changed 6 years ago by git

  • Commit changed from 80381a4d7d319c39f290965f225581bbe31dd44c to dd59939cc4b1a8bc986665499fc2c11f86f468a0

Branch pushed to git repo; I updated commit sha1. New commits:

dd59939"fixed white space in documentation"

comment:4 Changed 6 years ago by tscrim

  • Description modified (diff)

Some comments:

  • You should spell out the method names in full bounded_affine_permutation.
  • The INPUT: block should be - ``A`` -- a matrix with complex entries`.
  • You should move the OUTPUT: block to be right after the 1-line description and use latex formatting with single backticks, e.g., `i` with appropriate modifications to matrix it into a definition-type statement.
  • The OUTPUT: block should be something like A partial permutation of length `n` of `[2n]` , where `n` is ``A.ncols()``.
  • Remove the line For more on bounded affine permutations, see.
  • You can use the more simple (and Python3 compatible) S = Permutations(2*n, n).
  • You should use the base ring/field of A as the user might want more precision or use a particular subset of C.

comment:5 Changed 5 years ago by tscrim

  • Branch changed from u/rkarpman/22187bdd_affine to public/combinat/bounded_affine_permutation-22187
  • Commit changed from dd59939cc4b1a8bc986665499fc2c11f86f468a0 to fafc898917e20f3ec20c769b148a4a9688383418
  • Description modified (diff)
  • Milestone changed from sage-7.6 to sage-8.0
  • Reviewers set to Travis Scrimshaw

I've implemented the changes I suggested in comment:4. Just needs someone else to take a look.


New commits:

095760eMerge branch 'u/rkarpman/22187bdd_affine' of git://trac.sagemath.org/sage into public/combinat/bounded_affine_permutation-22187
fafc898Some reviewer changes.

comment:6 Changed 5 years ago by git

  • Commit changed from fafc898917e20f3ec20c769b148a4a9688383418 to 6b8ada7d3daaae384a48e5870e564288b377ffba

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6b8ada7Some reviewer changes.

comment:7 Changed 5 years ago by git

  • Commit changed from 6b8ada7d3daaae384a48e5870e564288b377ffba to 8862fa12d4f1c008588cf8cc2eeb4043dfd8cf8b

Branch pushed to git repo; I updated commit sha1. New commits:

c2d250aMerge branch 'public/combinat/bounded_affine_permutation-22187' in 8.0.b8
8862fa1trac 22187 details (pep8)

comment:8 Changed 5 years ago by chapoton

ok, looks good to me. Travis, please double check my small changes.

comment:9 Changed 5 years ago by tscrim

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from needs_review to positive_review

LGTM.

comment:10 Changed 5 years ago by vbraun

  • Branch changed from public/combinat/bounded_affine_permutation-22187 to 8862fa12d4f1c008588cf8cc2eeb4043dfd8cf8b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.