Opened 6 years ago

Closed 6 years ago

#22185 closed enhancement (fixed)

Rename gen -> Gen

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.6
Component: interfaces Keywords: atelierpari2017
Cc: Luca De Feo, Vincent Delecroix Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 0c4433c (Commits, GitHub, GitLab) Commit: 0c4433cf66fb6d9f5fcb5b4429d9f25978008f36
Dependencies: #21756, #21806, #21807, #21808, #21809, #21810, #22183 Stopgaps:

Status badges

Description

For consistency, use a capital for the class name.

This will also allow from .gen import Gen in __init__.py (which doesn't work if the class has the same name as the module).

Change History (8)

comment:1 Changed 6 years ago by Jeroen Demeyer

Cc: Luca De Feo Vincent Delecroix added

comment:2 Changed 6 years ago by Jeroen Demeyer

Keywords: atelierpari2017 added

comment:3 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/22185

comment:4 Changed 6 years ago by git

Commit: 0c4433cf66fb6d9f5fcb5b4429d9f25978008f36

Branch pushed to git repo; I updated commit sha1. New commits:

0c4433cFix documentation

comment:5 Changed 6 years ago by Jeroen Demeyer

Status: newneeds_review

comment:6 Changed 6 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

comment:7 Changed 6 years ago by Jeroen Demeyer

Thanks!

comment:8 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/ticket/221850c4433cf66fb6d9f5fcb5b4429d9f25978008f36
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.