#22163 closed defect (fixed)
giac has undeclared dependency on libpng
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-7.5 |
Component: | packages: standard | Keywords: | atelierpari2017 |
Cc: | frederichan | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Jean-Pierre Flori |
Report Upstream: | N/A | Work issues: | |
Branch: | 015a7d8 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description
Change History (12)
comment:1 Changed 6 years ago by
- Branch set to u/jdemeyer/giac_has_undeclared_dependency_on_libpng
comment:2 Changed 6 years ago by
- Cc frederichan added
- Commit set to 015a7d8dfb67b33eac47982545706621e6e77f25
comment:3 Changed 6 years ago by
- Status changed from new to needs_review
comment:4 Changed 6 years ago by
- Reviewers set to Jean-Pierre Flori
Does GIAC use -lpng1x rather than -lpng? Or should we patch?
comment:5 Changed 6 years ago by
during the spkg built my Makefile have this:
LIBS = -lrt -lpthread -ldl -lpng -lm -lmpfi -lmpfr -lgmp LIBTERMCAP = -ltermcap
comment:6 Changed 6 years ago by
We probably should patch. But that's not an issue for this ticket.
comment:7 Changed 6 years ago by
- Status changed from needs_review to positive_review
Ok so let's already merge this.
comment:8 Changed 6 years ago by
- Keywords atelierpari2017 added
comment:9 follow-up: ↓ 10 Changed 6 years ago by
FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.
comment:10 in reply to: ↑ 9 ; follow-up: ↓ 12 Changed 6 years ago by
Replying to jpflori:
FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.
Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.
comment:11 Changed 6 years ago by
- Branch changed from u/jdemeyer/giac_has_undeclared_dependency_on_libpng to 015a7d8dfb67b33eac47982545706621e6e77f25
- Resolution set to fixed
- Status changed from positive_review to closed
comment:12 in reply to: ↑ 10 Changed 5 years ago by
- Commit 015a7d8dfb67b33eac47982545706621e6e77f25 deleted
Replying to frederichan:
Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.
For what it worth, for Sage Debian Live, i compile giac (from within Sage) with xcas support, by installing the system's fltk, remove the --disable
flag and the nofltk-check.patch
, so i guess for such a graphical use, png support could be useful.
What would be a correct patch (so that i can add it to SDL until it get fixed) ?
New commits:
giac depends on libpng