Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22163 closed defect (fixed)

giac has undeclared dependency on libpng

Reported by: jdemeyer Owned by:
Priority: critical Milestone: sage-7.5
Component: packages: standard Keywords: atelierpari2017
Cc: frederichan Merged in:
Authors: Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 015a7d8 (Commits) Commit:
Dependencies: Stopgaps:

Description


Change History (12)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/giac_has_undeclared_dependency_on_libpng

comment:2 Changed 3 years ago by jdemeyer

  • Cc frederichan added
  • Commit set to 015a7d8dfb67b33eac47982545706621e6e77f25

New commits:

​015a7d8giac depends on libpng

comment:3 Changed 3 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 3 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori

Does GIAC use -lpng1x rather than -lpng? Or should we patch?

comment:5 Changed 3 years ago by frederichan

during the spkg built my Makefile have this: 

LIBS = -lrt -lpthread -ldl -lpng -lm -lmpfi -lmpfr -lgmp 
LIBTERMCAP = -ltermcap

comment:6 Changed 3 years ago by jdemeyer

We probably should patch. But that's not an issue for this ticket.

comment:7 Changed 3 years ago by jpflori

  • Status changed from needs_review to positive_review

Ok so let's already merge this.

comment:8 Changed 3 years ago by jdemeyer

  • Keywords atelierpari2017 added

comment:9 follow-up: Changed 3 years ago by jpflori

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 3 years ago by frederichan

Replying to jpflori:

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/giac_has_undeclared_dependency_on_libpng to 015a7d8dfb67b33eac47982545706621e6e77f25
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 in reply to: ↑ 10 Changed 3 years ago by tmonteil

  • Commit 015a7d8dfb67b33eac47982545706621e6e77f25 deleted

Replying to frederichan:

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

For what it worth, for ​Sage Debian Live, i compile giac (from within Sage) with xcas support, by installing the system's fltk, remove the --disable flag and the nofltk-check.patch, so i guess for such a graphical use, png support could be useful.

What would be a correct patch (so that i can add it to SDL until it get fixed) ?

Last edited 3 years ago by tmonteil (previous) (diff)
Note: See TracTickets for help on using tickets.