Opened 6 years ago

Last modified 6 weeks ago

#22150 needs_work enhancement

Set embedding of extension in QQ[2^(1/3)]

Reported by: vdelecroix Owned by:
Priority: major Milestone:
Component: number fields Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers:
Report Upstream: N/A Work issues: see patchbot report
Branch: u/vdelecroix/22150 (Commits, GitHub, GitLab) Commit: 3360768681a2d913a9ec7987aa423278aca15cf5
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by vdelecroix)

Before

sage: QQ[2^(1/3)].coerce_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Real Lazy Field
  Defn: a -> 1.259921049894873?

After

sage: QQ[2^(1/3)].coerce_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Algebraic Real Field
  Defn: a -> 1.259921049894873?

Change History (11)

comment:1 Changed 6 years ago by vdelecroix

Branch: u/vdelecroix/22150
Commit: 3360768681a2d913a9ec7987aa423278aca15cf5
Status: newneeds_review

New commits:

336076822150 set embedding appropriately in QQ[2^(1/3)]

comment:2 Changed 6 years ago by mmezzarobba

Status: needs_reviewneeds_work
Work issues: see patchbot report

comment:3 Changed 6 years ago by chapoton

Needs rebase.

Moreover, there is a problem coming from

sage: sqrt(-3).is_real()
True

comment:4 Changed 6 years ago by mmezzarobba

Whoops, I had forgotten about this ticket, but see #23117.

comment:5 Changed 6 years ago by chapoton

Milestone: sage-7.5sage-duplicate/invalid/wontfix
Status: needs_workneeds_review

so we can close this as duplicate, right ?

comment:6 Changed 6 years ago by chapoton

Hmm. currently we get:

Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Real Lazy Field
  Defn: a -> 1.259921049894873?

with target the real lazy field instead of AA.

comment:7 Changed 6 years ago by vdelecroix

Milestone: sage-duplicate/invalid/wontfixsage-8.0
Status: needs_reviewneeds_work

It would have been better if you just have read the ticket description.

comment:8 Changed 6 years ago by chapoton

What do you mean ? The ticket description is no longer valid...

comment:9 Changed 6 years ago by vdelecroix

Description: modified (diff)

The branch is not either. I think that #23117 was actually a bad idea. Coercion should not go through the real lazy field.

comment:10 in reply to:  9 Changed 6 years ago by mmezzarobba

Replying to vdelecroix:

The branch is not either. I think that #23117 was actually a bad idea. Coercion should not go through the real lazy field.

I agree that complex embeddings should go to QQbar or something like that by default, but for me this is a separate issue, already tracked elsewhere.

However, having the K[α] syntax create the “standard” embedding makes more sense to me (less confusing, probably breaks fewer existing things) than having it attempt to embed the number field in α's parent or something like that—if that's what you have in mind.

comment:11 Changed 6 weeks ago by mkoeppe

Milestone: sage-8.0
Note: See TracTickets for help on using tickets.