Opened 3 years ago
Closed 3 years ago
#22140 closed enhancement (fixed)
remove "import sage" from sage.rings.asymptotic.*
Reported by: | dkrenn | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.6 |
Component: | asymptotic expansions | Keywords: | |
Cc: | behackl, cheuberg | Merged in: | |
Authors: | Daniel Krenn | Reviewers: | Clemens Heuberger, Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | a259b95 (Commits) | Commit: | a259b955f857c4e7927a65975a9b61cd05386544 |
Dependencies: | Stopgaps: |
Description
Change History (8)
comment:1 Changed 3 years ago by
- Branch set to u/dkrenn/asy/import-sage
comment:2 Changed 3 years ago by
- Cc behackl cheuberg added
- Commit set to a259b955f857c4e7927a65975a9b61cd05386544
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Priority changed from major to minor
- Reviewers set to Clemens Heuberger
LGTM. I am waiting for a patchbot to test the ticket.
comment:4 follow-up: ↓ 5 Changed 3 years ago by
- Reviewers changed from Clemens Heuberger to Clemens Heuberger, Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, thanks, let it be (I was the one that wrote "what !!!")
comment:5 in reply to: ↑ 4 Changed 3 years ago by
Replying to chapoton:
(I was the one that wrote "what !!!")
This was one motivation for this patch ;)
comment:6 Changed 3 years ago by
There remains a few others such ugly things:
git grep "^import sage$" src/sage/combinat/finite_state_machine.py:import sage src/sage/rings/asymptotic/growth_group.py:import sage src/sage/rings/asymptotic/growth_group_cartesian.py:import sage src/sage/rings/asymptotic/term_monoid.py:import sage src/sage/rings/complex_mpc.pyx:import sage src/sage/rings/noncommutative_ideals.pyx:import sage src/sage/sets/finite_set_map_cy.pyx:import sage src/sage/structure/list_clone.pyx:import sage src/sage/structure/list_clone_timings_cy.pyx:import sage
comment:7 Changed 3 years ago by
- Milestone changed from sage-7.5 to sage-7.6
comment:8 Changed 3 years ago by
- Branch changed from u/dkrenn/asy/import-sage to a259b955f857c4e7927a65975a9b61cd05386544
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
remove "import sage" from sage.rings.asymptotic.*