Opened 3 years ago

Closed 3 years ago

#22137 closed enhancement (fixed)

LatticePoset: Add certificate for is_join_semidistributive

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-7.6
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: eac575f (Commits) Commit: eac575fb9fc6be6bcf6b8bcce05e9af87aabf694
Dependencies: Stopgaps:

Description

Trivial dual of #22133.

Change History (8)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/join-semidist-cert

comment:2 Changed 3 years ago by jmantysalo

  • Cc tscrim added
  • Commit set to 97a2de20424ce114c044c0704f7382e53b838fc1
  • Status changed from new to needs_review

New commits:

97a2de2Add certificate to is_join_semidistributive.

comment:3 follow-up: Changed 3 years ago by tscrim

It would be a little cleaner if you put both if statements in the for loop in one line. If you put the inner one second, short-circuiting will mean it has the same running speed. We should also do this on #22133 too.

comment:4 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to needs_work

comment:5 Changed 3 years ago by git

  • Commit changed from 97a2de20424ce114c044c0704f7382e53b838fc1 to eac575fb9fc6be6bcf6b8bcce05e9af87aabf694

Branch pushed to git repo; I updated commit sha1. New commits:

eac575fFrom if-if to if-and.

comment:6 in reply to: ↑ 3 Changed 3 years ago by jmantysalo

  • Status changed from needs_work to needs_review

Replying to tscrim:

It would be a little cleaner if you put both if statements in the for loop in one line.

Good point. Done.

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Thanks.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/join-semidist-cert to eac575fb9fc6be6bcf6b8bcce05e9af87aabf694
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.