Opened 5 years ago

Closed 5 years ago

#22122 closed enhancement (fixed)

Remove deprecated code in geometry

Reported by: novoselt Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords:
Cc: vbraun Merged in:
Authors: Andrey Novoseltsev Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 4599dcc (Commits, GitHub, GitLab) Commit: 4599dccf866107a36abbb20db76a0dca6e3842d5
Dependencies: Stopgaps:

Status badges

Description (last modified by novoselt)

Remove stuff deprecated in #16180, #19070 and #19071.

Also some code clean up like removing unused variables, imports, and stale commented code.

Change History (6)

comment:1 Changed 5 years ago by novoselt

  • Description modified (diff)

comment:2 Changed 5 years ago by novoselt

  • Branch set to u/novoselt/22122

comment:3 Changed 5 years ago by novoselt

  • Cc vbraun added
  • Commit set to 4599dccf866107a36abbb20db76a0dca6e3842d5
  • Status changed from new to needs_review

New commits:

4599dccRemove old-style faces of lattice polytopes

comment:4 Changed 5 years ago by saraedum

  • Reviewers set to Julian Rüth

Feel free to set this to positive review if you think that the patchbot error is unrelated.

comment:5 Changed 5 years ago by novoselt

  • Status changed from needs_review to positive_review

I do think that they are unrelated, and they are different for beta0 and beta1. Thank you for taking a look!

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/novoselt/22122 to 4599dccf866107a36abbb20db76a0dca6e3842d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.