Opened 6 years ago
Closed 6 years ago
#22121 closed enhancement (fixed)
py3 : futureproof map in doctests of combinat folder
Reported by:  Frédéric Chapoton  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  python3  Keywords:  
Cc:  Travis Scrimshaw, Jeroen Demeyer, aapitzsch, Jori Mäntysalo  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  ef85cbc (Commits, GitHub, GitLab)  Commit:  ef85cbc6cfb7f2a0076b3bb4529cb410aec245c7 
Dependencies:  Stopgaps: 
Description (last modified by )
as a step towards python3
let us write the doctests so that map can be an iterator
here in combinat folder
part of #16073
Change History (7)
comment:1 Changed 6 years ago by
Branch:  → u/chapoton/22121 

Cc:  Travis Scrimshaw Jeroen Demeyer aapitzsch Jori Mäntysalo added 
Commit:  → 01f27e999e714b9908b50c74cbc712512e1c1e2d 
Status:  new → needs_review 
comment:2 Changed 6 years ago by
Commit:  01f27e999e714b9908b50c74cbc712512e1c1e2d → ef85cbc6cfb7f2a0076b3bb4529cb410aec245c7 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ef85cbc  more futureproof doctests w.r.t. to "map" in "combinat"

comment:3 Changed 6 years ago by
Milestone:  sage7.5 → sage7.6 

Reviewers:  → Travis Scrimshaw 
Is there a reason why you changed some of them to list comprehension and some to list(map(foo, bar))
? I understand the ones with lambda
functions, but there are some that changed seeming arbitrary. I just am curious if there was a reason.
comment:4 Changed 6 years ago by
no special reason. I turned things into list comprehension when it was easy and quick, and went to the simple but ugly solution otherwise.
comment:5 Changed 6 years ago by
Description:  modified (diff) 

comment:6 Changed 6 years ago by
Status:  needs_review → positive_review 

That's something what I figured, but thought I'd check just to be sure.
comment:7 Changed 6 years ago by
Branch:  u/chapoton/22121 → ef85cbc6cfb7f2a0076b3bb4529cb410aec245c7 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
PY3 get rid of the last .itervalues() in py files
more futureproof doctests w.r.t. to "map" in "combinat"