Opened 3 years ago

Closed 3 years ago

#22114 closed enhancement (fixed)

change type to ... in src/doc

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: tscrim, jmantysalo, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 773945c (Commits) Commit: 773945c6359f1c9b90e2be72fd0182d10050b5fb
Dependencies: Stopgaps:

Description

part of #16085

needed for the tests to pass with Py3

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22114
  • Cc tscrim jmantysalo aapitzsch added
  • Commit set to 773945c6359f1c9b90e2be72fd0182d10050b5fb
  • Status changed from new to needs_review

New commits:

​aef20f0type list > ... list
​f816c1btype str > ... str
​9331d81type tuple > ... tuple
​4745b17type function > ... function
​773945ctype int,dict,float > ... int,dict,float

comment:2 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I'll take.

comment:3 Changed 3 years ago by jmantysalo

  • Milestone changed from sage-7.5 to sage-7.6
  • Status changed from needs_review to positive_review

OK. Were these done with 

find ... | xargs perl -e "s|(^ +<)type ('[^']+'>$)|\1... \2|g;" -p -i.bak

?

rc1 is out, so I changed the milestone.

comment:4 Changed 3 years ago by chapoton

This was done with several grep and replace, indeed, but I left out the case of "<type 'instancemethod'>" because I do not know the behavior of that in Py3.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22114 to 773945c6359f1c9b90e2be72fd0182d10050b5fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.