Opened 3 years ago

Closed 3 years ago

#22110 closed defect (fixed)

downgrade modular_decomposition package to experimental

Reported by: dimpase Owned by:
Priority: critical Milestone: sage-7.5
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 5b4fc8b (Commits) Commit: 5b4fc8bc33dd2bcfdf2027941565d62bf4b541f1
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The optional package modular_decomposition either renders Sage broken, or gives a lot of wrong results.

Downgrading it to experimental would at least give more warnings to potential users.

Change History (8)

comment:1 Changed 3 years ago by dimpase

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from downgrade optional packages causing errors to downgrade modular_decomposition package to experimental

Can you elaborate what is the problem with this package?

comment:3 Changed 3 years ago by dimpase

It gives wrong results on many inputs. Moreover it is abandoned by the original upstream author(s). See e.g. here. The latest example.

There is also a stopgap, and I think #17950 should have made it experimental already.

PS. There is no implementation available to hook up (neither Java nor Perl implementations are useful for us). Would make a good student/GSoC project, I suppose...

Last edited 3 years ago by dimpase (previous) (diff)

comment:4 Changed 3 years ago by dimpase

  • Branch set to u/dimpase/moddecexp
  • Commit set to 5b4fc8bc33dd2bcfdf2027941565d62bf4b541f1
  • Priority changed from major to critical
  • Status changed from new to needs_review

New commits:

5b4fc8bdowngrade to exp

comment:5 Changed 3 years ago by jdemeyer

Personally, I think the stopgap is a sufficient solution. But I'm not against the downgrade to experimental.

Let me just check if it still builds properly...

comment:6 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Author name...

comment:7 Changed 3 years ago by dimpase

  • Authors set to Dima Pasechnik

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/moddecexp to 5b4fc8bc33dd2bcfdf2027941565d62bf4b541f1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.