Opened 7 years ago
Closed 5 years ago
#16821 closed enhancement (fixed)
Implement classical Lie algebras
Reported by:  tscrim  Owned by:  tscrim 

Priority:  major  Milestone:  sage8.0 
Component:  algebra  Keywords:  lie algebras, days64, days74, days78 
Cc:  darij, egourgoulhon  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Aram Dermenjian 
Report Upstream:  N/A  Work issues:  
Branch:  5cbde34 (Commits, GitHub, GitLab)  Commit:  5cbde34d4987724a7cf036e00c180ec94df73864 
Dependencies:  #16820  Stopgaps: 
Description
Part of #14901. Implements the classical Lie algebras given by matrices and by the basis.
Change History (24)
comment:1 Changed 7 years ago by
 Dependencies set to #16819
comment:2 Changed 7 years ago by
 Dependencies changed from #16819 to #16820, #17944
comment:3 Changed 7 years ago by
 Branch set to public/lie_algebras/classical16821
 Commit set to 3b64a5db15d23c9d89ba2b67d4cf6b3275f23336
 Status changed from new to needs_review
comment:4 Changed 7 years ago by
 Keywords days64 added
 Milestone changed from sage6.4 to sage6.6
comment:5 Changed 6 years ago by
 Commit changed from 3b64a5db15d23c9d89ba2b67d4cf6b3275f23336 to 80f9731f84ba73e86a971e7d0e5dc258f6d52598
Branch pushed to git repo; I updated commit sha1. New commits:
80f9731  fixed merge conflict

comment:6 Changed 6 years ago by
 Milestone changed from sage6.6 to sage6.10
comment:7 Changed 6 years ago by
From patchbot report.
[algebras ] loading cross citations... [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/classical_lie_algebra.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/examples.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/heisenberg.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/lie_algebra.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/lie_algebra_element.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/structure_coefficients.py' [algebras ] /home/kevin/sage/src/doc/en/reference/algebras/lie_algebras.rst:4: WARNING: toctree contains reference to nonexisting document u'sage/algebras/lie_algebras/virasoro.py' Error building the documentation.
comment:8 Changed 6 years ago by
 Commit changed from 80f9731f84ba73e86a971e7d0e5dc258f6d52598 to cedb619d2a830b6309254080946db515e1329281
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
6815f1c  review heisenberg.py again; coercion still relies on unstaged changes to module morphisms

573e074  Merge branch 'public/lie_algebras/fd_structure_coeff16820' of trac.sagemath.org:sage into public/lie_algebras/fd_structure_coeff16820

3f9a4a1  Fixing the failing doctests and making the doc build.

b9930e6  some changes to standardization of names

60f743a  Parsing the input so that it uses the indexing set.

a02380f  Merge branch 'public/lie_algebras/fd_structure_coeff16820' in 7.0.rc1

50f4441  trac #16820 correct the spelling of Cartesian

f1514bd  Merge branch 'public/lie_algebras/fd_structure_coeff16820' into 7.3.b2

7d155ec  Fixing trivial doctest failures.

cedb619  Merge branch 'public/lie_algebras/classical16821' of trac.sagemath.org:sage into public/lie_algebras/classical16821

comment:9 Changed 6 years ago by
 Keywords days74 added
 Milestone changed from sage6.10 to sage7.3
comment:10 Changed 6 years ago by
 Commit changed from cedb619d2a830b6309254080946db515e1329281 to 0a17e62969e7831189d09b6882bb63626140176e
comment:11 Changed 6 years ago by
 Commit changed from 0a17e62969e7831189d09b6882bb63626140176e to 721632bca52b77c3f628ff3b0d2919548579e81c
comment:12 Changed 6 years ago by
 Commit changed from 721632bca52b77c3f628ff3b0d2919548579e81c to 23c1474d7c116fec63cbc643446e64ee2ad38e6f
Branch pushed to git repo; I updated commit sha1. New commits:
23c1474  Implementing matrix Lie algebras in types E6, F4, and G2.

comment:13 Changed 5 years ago by
 Commit changed from 23c1474d7c116fec63cbc643446e64ee2ad38e6f to abcf1e542ac7a3cae36a42fb6adf72b277ae6839
comment:14 followup: ↓ 15 Changed 5 years ago by
I've reviewed most of the math and have done some testing here and there on this. It looks good from my perspective.
From what I recall there needs to be a second reviewer? If so, then I'll leave it open until there is a second reviewer to approve this.
comment:15 in reply to: ↑ 14 Changed 5 years ago by
 Keywords days78 added
Replying to aram.dermenjian:
I've reviewed most of the math and have done some testing here and there on this. It looks good from my perspective.
From what I recall there needs to be a second reviewer? If so, then I'll leave it open until there is a second reviewer to approve this.
No, Sage only requires one reviewer. So once you add your (real) name to the reviewers, you can set a positive review.
comment:16 Changed 5 years ago by
 Reviewers set to Aram Dermenjian
 Status changed from needs_review to positive_review
comment:17 Changed 5 years ago by
Thank you!
comment:18 Changed 5 years ago by
 Dependencies changed from #16820, #17944 to #16820
 Status changed from positive_review to needs_work
 Work issues set to merge
Neither the dependency #16820 nor latest develop merges cleanly with this branch.
Note that I'm not particularly interested in this ticket, I just randomly noticed this.
comment:19 Changed 5 years ago by
 Commit changed from abcf1e542ac7a3cae36a42fb6adf72b277ae6839 to 5cbde34d4987724a7cf036e00c180ec94df73864
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
e8c5256  Merge branch 'public/lie_algebras/fd_structure_coeff16820' in 7.5.rc1

7c92fd1  trac 16820 nonzero > bool

a9d636c  Merge branch 'public/lie_algebras/fd_structure_coeff16820' in 7.6.b5

7bda1a4  trac 16820 get rid of some .iteritems in py files

3e2c547  Merge branch 'public/lie_algebras/fd_structure_coeff16820' of git://trac.sagemath.org/sage into public/lie_algebras/fd_structure_coeff16820

cf88fee  Changes for the reviewer and using standard copyright.

42666d4  Adding centralizer_basis method, improving to/from_vector for finitedim Lie algebras, other fixes.

59df7ce  Fixing pdf docbuild in finitedim Lie algebras w/ basis category.

600a87a  Merge branch 'public/lie_algebras/classical16821' of git://trac.sagemath.org/sage into public/lie_algebras/classical16821

5cbde34  Doing rebasing due to changes in base ticket.

comment:20 followup: ↓ 21 Changed 5 years ago by
 Cc darij egourgoulhon added
 Milestone changed from sage7.3 to sage8.0
 Status changed from needs_work to needs_review
 Work issues merge deleted
This just needs someone to check that nothing broke from my rebase.
comment:21 in reply to: ↑ 20 Changed 5 years ago by
comment:22 Changed 5 years ago by
Can I treat that reset to positive review?
Edit  The patchbot failure is fixed by recent changes to #16820.
comment:23 Changed 5 years ago by
 Status changed from needs_review to positive_review
Looks good to me.
comment:24 Changed 5 years ago by
 Branch changed from public/lie_algebras/classical16821 to 5cbde34d4987724a7cf036e00c180ec94df73864
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Merge branch 'public/categories/lie_algebras16819' into public/lie_algebras/fd_structure_coeff16820
Added files to the documentation.
Added more methods for root lattices.
Merge branch 'public/combinat/more_root_lattice_methods17944' into public/lie_algebras/classical16821
Initial import of classical Lie algebras.
Merge branch 'develop' into public/lie_algebras/classical16821
Finalizing doctests for classical Lie algebras.
Merge branch 'develop' into public/lie_algebras/fd_structure_coeff16820
Some last tweaks and getting full coverage.
Merge branch 'public/lie_algebras/fd_structure_coeff16820' into public/lie_algebras/classical16821