Opened 3 years ago

Closed 3 years ago

#22061 closed enhancement (fixed)

Don't hard-code the path to thebe.js

Reported by: embray Owned by:
Priority: minor Milestone: sage-7.6
Component: build Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 9175036 (Commits) Commit: 91750364453a3ecf4446a5566029c0eb963aa6cf
Dependencies: Stopgaps:


Currently the path to thebe.js is hard-coded in the form of a symlink relative to the doc source. Eventually one might want to be able to use this from an OS package instead, and not assume it's in $SAGE_LOCAL.

This can be viewed as a follow-up to #15105

Change History (5)

comment:1 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by embray

  • Type changed from PLEASE CHANGE to enhancement

comment:3 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:4 Changed 3 years ago by mkoeppe

  • Milestone changed from sage-7.5 to sage-7.6

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/embray/docs/thebe-path to 91750364453a3ecf4446a5566029c0eb963aa6cf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.