Opened 5 years ago

Closed 5 years ago

#22020 closed enhancement (fixed)

py3 get rid of cmp() in fraction field element pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.5
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: ebe69c7 (Commits, GitHub, GitLab) Commit: ebe69c7649d16043344e6cb26b5cde097e5af37f
Dependencies: Stopgaps:

Status badges

Description

as a step on the way to python3

Change History (4)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/22020
  • Commit set to ebe69c7649d16043344e6cb26b5cde097e5af37f
  • Status changed from new to needs_review

New commits:

​ebe69c7py3 get rid of cmp() in fraction field element pyx

comment:2 Changed 5 years ago by chapoton

bot is morally green, please review

comment:3 Changed 5 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

Since the failed tests seem unrelated, positive review.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/22020 to ebe69c7649d16043344e6cb26b5cde097e5af37f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.