Opened 3 years ago
Closed 3 years ago
#22013 closed enhancement (fixed)
py3 removing a few cmp() in rings
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | python3 | Keywords: | |
Cc: | jdemeyer, tscrim, aapitzsch | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | cfbef13 (Commits) | Commit: | cfbef1346dbdff15e8d882794c723635ad1c1ce5 |
Dependencies: | Stopgaps: |
Description
where _cmp_ is called by _richcmp and must be kept
Change History (11)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/22013
- Commit set to 91eda7fb3c91f2ba784544d896c42ccbef618d2d
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
*ping*
comment:4 Changed 3 years ago by
*ping*, similar to #22019
comment:5 Changed 3 years ago by
please, I would like this simple one to go on, even if it will need care again later..
comment:6 Changed 3 years ago by
I don't particularly like this test:
sage: ZZ <= QQ True
I know it was there before, but we are not imposing any sort of order on the parents I thought. So it doesn't make sense to test this IMO.
comment:7 Changed 3 years ago by
- Commit changed from 91eda7fb3c91f2ba784544d896c42ccbef618d2d to cfbef1346dbdff15e8d882794c723635ad1c1ce5
comment:8 Changed 3 years ago by
I changed the test, and also made just a few pep8 changes in the integer file.
comment:9 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Thanks.
comment:10 Changed 3 years ago by
- Milestone changed from sage-7.5 to sage-7.6
comment:11 Changed 3 years ago by
- Branch changed from u/chapoton/22013 to cfbef1346dbdff15e8d882794c723635ad1c1ce5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3 removing a few more cmp() in core code of rings