Opened 3 years ago

Closed 3 years ago

#22013 closed enhancement (fixed)

py3 removing a few cmp() in rings

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: jdemeyer, tscrim, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: cfbef13 (Commits) Commit: cfbef1346dbdff15e8d882794c723635ad1c1ce5
Dependencies: Stopgaps:

Description

where _cmp_ is called by _richcmp and must be kept

Change History (11)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22013
  • Commit set to 91eda7fb3c91f2ba784544d896c42ccbef618d2d
  • Status changed from new to needs_review

New commits:

91eda7fpy3 removing a few more cmp() in core code of rings

comment:2 Changed 3 years ago by chapoton

  • Cc jdemeyer tscrim aapitzsch added

green bot, please review

comment:3 Changed 3 years ago by chapoton

*ping*

comment:4 Changed 3 years ago by chapoton

*ping*, similar to #22019

comment:5 Changed 3 years ago by chapoton

please, I would like this simple one to go on, even if it will need care again later..

comment:6 Changed 3 years ago by tscrim

I don't particularly like this test:

sage: ZZ <= QQ
True

I know it was there before, but we are not imposing any sort of order on the parents I thought. So it doesn't make sense to test this IMO.

Last edited 3 years ago by tscrim (previous) (diff)

comment:7 Changed 3 years ago by git

  • Commit changed from 91eda7fb3c91f2ba784544d896c42ccbef618d2d to cfbef1346dbdff15e8d882794c723635ad1c1ce5

Branch pushed to git repo; I updated commit sha1. New commits:

f9f49abMerge branch 'u/chapoton/22013' in 7.5.rc1
cfbef13trac 22013 using ZZ != QQ as a test

comment:8 Changed 3 years ago by chapoton

I changed the test, and also made just a few pep8 changes in the integer file.

Last edited 3 years ago by chapoton (previous) (diff)

comment:9 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks.

comment:10 Changed 3 years ago by chapoton

  • Milestone changed from sage-7.5 to sage-7.6

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22013 to cfbef1346dbdff15e8d882794c723635ad1c1ce5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.